Re: [PATCH net-next v2 3/4] net: dsa: add support for offloading HSR

2021-02-09 Thread George McCollister
On Tue, Feb 9, 2021 at 12:51 PM Vladimir Oltean wrote: > > On Tue, Feb 09, 2021 at 12:37:38PM -0600, George McCollister wrote: > > On Tue, Feb 9, 2021 at 11:20 AM Vladimir Oltean wrote: > > > > > > On Mon, Feb 08, 2021 at 11:21:26AM -0600, George McCollister wrote: > > > > > If you return zero, t

Re: [PATCH net-next v2 3/4] net: dsa: add support for offloading HSR

2021-02-09 Thread Vladimir Oltean
On Tue, Feb 09, 2021 at 12:37:38PM -0600, George McCollister wrote: > On Tue, Feb 9, 2021 at 11:20 AM Vladimir Oltean wrote: > > > > On Mon, Feb 08, 2021 at 11:21:26AM -0600, George McCollister wrote: > > > > If you return zero, the software fallback is never going to kick in. > > > > > > For join

Re: [PATCH net-next v2 3/4] net: dsa: add support for offloading HSR

2021-02-09 Thread George McCollister
On Tue, Feb 9, 2021 at 11:20 AM Vladimir Oltean wrote: > > On Mon, Feb 08, 2021 at 11:21:26AM -0600, George McCollister wrote: > > > If you return zero, the software fallback is never going to kick in. > > > > For join and leave? How is this not a problem for the bridge and lag > > functions? They

Re: [PATCH net-next v2 3/4] net: dsa: add support for offloading HSR

2021-02-09 Thread Vladimir Oltean
On Mon, Feb 08, 2021 at 11:21:26AM -0600, George McCollister wrote: > > If you return zero, the software fallback is never going to kick in. > > For join and leave? How is this not a problem for the bridge and lag > functions? They work the same way don't they? I figured it would be > safe to follo

Re: [PATCH net-next v2 3/4] net: dsa: add support for offloading HSR

2021-02-08 Thread George McCollister
On Sat, Feb 6, 2021 at 5:29 PM Vladimir Oltean wrote: > > On Thu, Feb 04, 2021 at 03:59:25PM -0600, George McCollister wrote: > > @@ -1935,6 +1936,19 @@ static int dsa_slave_changeupper(struct net_device > > *dev, > > dsa_port_lag_leave(dp, info->upper_dev); > >

Re: [PATCH net-next v2 3/4] net: dsa: add support for offloading HSR

2021-02-06 Thread Vladimir Oltean
On Thu, Feb 04, 2021 at 03:59:25PM -0600, George McCollister wrote: > @@ -1935,6 +1936,19 @@ static int dsa_slave_changeupper(struct net_device > *dev, > dsa_port_lag_leave(dp, info->upper_dev); > err = NOTIFY_OK; > } > + } else if (is_

[PATCH net-next v2 3/4] net: dsa: add support for offloading HSR

2021-02-04 Thread George McCollister
Add support for offloading of HSR/PRP (IEC 62439-3) tag insertion tag removal, duplicate generation and forwarding on DSA switches. Add DSA_NOTIFIER_HSR_JOIN and DSA_NOTIFIER_HSR_LEAVE which trigger calls to .port_hsr_join and .port_hsr_leave in the DSA driver for the switch. The DSA switch drive