Re: [PATCH net-next v2 3/4] bpf, mlx5: drop priv->xdp_prog reference on netdev cleanup

2016-11-17 Thread Saeed Mahameed
On Wed, Nov 16, 2016 at 5:55 PM, Daniel Borkmann wrote: > On 11/16/2016 04:45 PM, Daniel Borkmann wrote: >> >> On 11/16/2016 01:51 PM, Saeed Mahameed wrote: >>> >>> On Wed, Nov 16, 2016 at 2:04 AM, Daniel Borkmann >>> wrote: mlx5e_xdp_set() is currently the only place where we drop refe

Re: [PATCH net-next v2 3/4] bpf, mlx5: drop priv->xdp_prog reference on netdev cleanup

2016-11-16 Thread Daniel Borkmann
On 11/16/2016 04:45 PM, Daniel Borkmann wrote: On 11/16/2016 01:51 PM, Saeed Mahameed wrote: On Wed, Nov 16, 2016 at 2:04 AM, Daniel Borkmann wrote: mlx5e_xdp_set() is currently the only place where we drop reference on the prog sitting in priv->xdp_prog when it's exchanged by a new one. We al

Re: [PATCH net-next v2 3/4] bpf, mlx5: drop priv->xdp_prog reference on netdev cleanup

2016-11-16 Thread Daniel Borkmann
On 11/16/2016 01:51 PM, Saeed Mahameed wrote: On Wed, Nov 16, 2016 at 2:04 AM, Daniel Borkmann wrote: mlx5e_xdp_set() is currently the only place where we drop reference on the prog sitting in priv->xdp_prog when it's exchanged by a new one. We also need to make sure that we eventually release

Re: [PATCH net-next v2 3/4] bpf, mlx5: drop priv->xdp_prog reference on netdev cleanup

2016-11-16 Thread Saeed Mahameed
On Wed, Nov 16, 2016 at 2:04 AM, Daniel Borkmann wrote: > mlx5e_xdp_set() is currently the only place where we drop reference on the > prog sitting in priv->xdp_prog when it's exchanged by a new one. We also > need to make sure that we eventually release that reference, for example, > in case the

[PATCH net-next v2 3/4] bpf, mlx5: drop priv->xdp_prog reference on netdev cleanup

2016-11-15 Thread Daniel Borkmann
mlx5e_xdp_set() is currently the only place where we drop reference on the prog sitting in priv->xdp_prog when it's exchanged by a new one. We also need to make sure that we eventually release that reference, for example, in case the netdev is dismantled. Fixes: 86994156c736 ("net/mlx5e: XDP fast