Re: [PATCH net-next v2 3/3] tools: bpftool: add documentation

2017-10-03 Thread David Ahern
On 10/3/17 9:01 AM, Daniel Borkmann wrote: > On 10/03/2017 05:39 PM, David Ahern wrote: >> On 10/2/17 9:29 PM, Alexei Starovoitov wrote: >>> On Mon, Oct 02, 2017 at 06:35:09PM -0700, Jakub Kicinski wrote: > will pretty print them as verifier output as well? We tried to use LLVM as a l

Re: [PATCH net-next v2 3/3] tools: bpftool: add documentation

2017-10-03 Thread Daniel Borkmann
On 10/03/2017 05:39 PM, David Ahern wrote: On 10/2/17 9:29 PM, Alexei Starovoitov wrote: On Mon, Oct 02, 2017 at 06:35:09PM -0700, Jakub Kicinski wrote: will pretty print them as verifier output as well? We tried to use LLVM as a library for this but the interface is painfully unstable and it

Re: [PATCH net-next v2 3/3] tools: bpftool: add documentation

2017-10-03 Thread David Ahern
On 10/2/17 9:29 PM, Alexei Starovoitov wrote: > On Mon, Oct 02, 2017 at 06:35:09PM -0700, Jakub Kicinski wrote: >>> will pretty print them as verifier output as well? >> >> We tried to use LLVM as a library for this but the interface is >> painfully unstable and it's a heavy dependency. The curren

Re: [PATCH net-next v2 3/3] tools: bpftool: add documentation

2017-10-03 Thread Daniel Borkmann
On 10/03/2017 03:35 AM, Jakub Kicinski wrote: On Mon, 2 Oct 2017 17:55:02 -0700, Alexei Starovoitov wrote: +EXAMPLES + +**# bpftool prog show** +:: + + 10: xdp name:some_prog tag 00:5a:3d:21:23:62:0c:8b could you please remove ':' in the output to match what show_fdinfo and kallsyms

Re: [PATCH net-next v2 3/3] tools: bpftool: add documentation

2017-10-02 Thread Alexei Starovoitov
On Mon, Oct 02, 2017 at 06:35:09PM -0700, Jakub Kicinski wrote: > > will pretty print them as verifier output as well? > > We tried to use LLVM as a library for this but the interface is > painfully unstable and it's a heavy dependency. The current thinking > is to try to put the instruction prin

Re: [PATCH net-next v2 3/3] tools: bpftool: add documentation

2017-10-02 Thread Jakub Kicinski
On Mon, 2 Oct 2017 17:55:02 -0700, Alexei Starovoitov wrote: > > +EXAMPLES > > + > > +**# bpftool prog show** > > +:: > > + > > + 10: xdp name:some_prog tag 00:5a:3d:21:23:62:0c:8b > > could you please remove ':' in the output to match what > show_fdinfo and kallsyms do ? Ack. > > +

Re: [PATCH net-next v2 3/3] tools: bpftool: add documentation

2017-10-02 Thread Alexei Starovoitov
On Mon, Oct 02, 2017 at 04:11:30PM -0700, Jakub Kicinski wrote: > Add documentation for bpftool. Separate files for each subcommand. > Use rst format. Documentation is compiled into man pages using > rst2man. > > Signed-off-by: David Beckett > Signed-off-by: Jakub Kicinski > --- > tools/bpf/b

[PATCH net-next v2 3/3] tools: bpftool: add documentation

2017-10-02 Thread Jakub Kicinski
Add documentation for bpftool. Separate files for each subcommand. Use rst format. Documentation is compiled into man pages using rst2man. Signed-off-by: David Beckett Signed-off-by: Jakub Kicinski --- tools/bpf/bpftool/Documentation/Makefile | 34 +++ tools/bpf/bpftool/Documenta