Re: [PATCH net-next v2 3/3] dpaa2-eth: Add pause frame support

2019-08-28 Thread David Miller
From: Andrew Lunn Date: Wed, 28 Aug 2019 13:52:50 +0200 >> Clearing the ASYM_PAUSE flag only means we tell the firmware we want >> both Rx and Tx pause to be enabled in the beginning. User can still set >> an asymmetric config (i.e. only Rx pause or only Tx pause to be enabled) >> if needed. >>

RE: [PATCH net-next v2 3/3] dpaa2-eth: Add pause frame support

2019-08-28 Thread Ioana Ciocoi Radulescu
> -Original Message- > From: Andrew Lunn > Sent: Wednesday, August 28, 2019 2:53 PM > To: Ioana Ciocoi Radulescu > Cc: netdev@vger.kernel.org; da...@davemloft.net; Ioana Ciornei > > Subject: Re: [PATCH net-next v2 3/3] dpaa2-eth: Add pause frame support > >

Re: [PATCH net-next v2 3/3] dpaa2-eth: Add pause frame support

2019-08-28 Thread Andrew Lunn
> Clearing the ASYM_PAUSE flag only means we tell the firmware we want > both Rx and Tx pause to be enabled in the beginning. User can still set > an asymmetric config (i.e. only Rx pause or only Tx pause to be enabled) > if needed. > > The truth table is like this: > > PAUSE | ASYM_PAUSE | Rx pa

RE: [PATCH net-next v2 3/3] dpaa2-eth: Add pause frame support

2019-08-28 Thread Ioana Ciocoi Radulescu
> -Original Message- > From: Andrew Lunn > Sent: Wednesday, August 28, 2019 2:22 AM > To: Ioana Ciocoi Radulescu > Cc: netdev@vger.kernel.org; da...@davemloft.net; Ioana Ciornei > > Subject: Re: [PATCH net-next v2 3/3] dpaa2-eth: Add pause frame support > >

Re: [PATCH net-next v2 3/3] dpaa2-eth: Add pause frame support

2019-08-27 Thread Andrew Lunn
On Tue, Aug 27, 2019 at 05:15:51PM +0300, Ioana Radulescu wrote: > Starting with firmware version MC10.18.0, we have support for > L2 flow control. Asymmetrical configuration (Rx or Tx only) is > supported, but not pause frame autonegotioation. > +static int set_pause(struct dpaa2_eth_priv *priv)

[PATCH net-next v2 3/3] dpaa2-eth: Add pause frame support

2019-08-27 Thread Ioana Radulescu
Starting with firmware version MC10.18.0, we have support for L2 flow control. Asymmetrical configuration (Rx or Tx only) is supported, but not pause frame autonegotioation. Pause frame configuration is done via ethtool. By default, we start with flow control enabled on both Rx and Tx. Changes are