Re: [PATCH net-next v2 2/3] openvswitch: remove unreachable code in vlan parsing

2016-10-06 Thread Jiri Benc
On Wed, 5 Oct 2016 22:22:13 -0700, Pravin Shelar wrote: > User can turn off TX vlan offload for OVS internal device that would > allow vlan tagged packet with vlan header on the skb-data. This case > will cause issue here. Good catch. This is the feedback I hoped for, not the bikesheding about a v

Re: [PATCH net-next v2 2/3] openvswitch: remove unreachable code in vlan parsing

2016-10-05 Thread Pravin Shelar
On Wed, Oct 5, 2016 at 6:07 AM, Jiri Benc wrote: > Now when the first vlan tag is always in skb->vlan_tci, drop code that > assumed it might not be the case. > User can turn off TX vlan offload for OVS internal device that would allow vlan tagged packet with vlan header on the skb-data. This case

[PATCH net-next v2 2/3] openvswitch: remove unreachable code in vlan parsing

2016-10-05 Thread Jiri Benc
Now when the first vlan tag is always in skb->vlan_tci, drop code that assumed it might not be the case. This patch also removes the wrong likely() statement around skb_vlan_tag_present introduced by 018c1dda5ff1 ("openvswitch: 802.1AD Flow handling, actions, vlan parsing, netlink attributes"). Th