Re: [PATCH net-next v2 1/8] ethtool: add standard pause stats

2020-09-14 Thread Jakub Kicinski
On Mon, 14 Sep 2020 19:18:08 +0200 Andrew Lunn wrote: > On Mon, Sep 14, 2020 at 08:48:10AM -0700, Jakub Kicinski wrote: > > On Mon, 14 Sep 2020 03:48:40 +0200 Andrew Lunn wrote: > > > > static int pause_prepare_data(const struct ethnl_req_info *req_base, > > > > @@ -34,10 +36,17 @@ static int pa

Re: [PATCH net-next v2 1/8] ethtool: add standard pause stats

2020-09-14 Thread Andrew Lunn
On Mon, Sep 14, 2020 at 08:48:10AM -0700, Jakub Kicinski wrote: > On Mon, 14 Sep 2020 03:48:40 +0200 Andrew Lunn wrote: > > > static int pause_prepare_data(const struct ethnl_req_info *req_base, > > > @@ -34,10 +36,17 @@ static int pause_prepare_data(const struct > > > ethnl_req_info *req_base, >

Re: [PATCH net-next v2 1/8] ethtool: add standard pause stats

2020-09-14 Thread Jakub Kicinski
On Mon, 14 Sep 2020 03:48:40 +0200 Andrew Lunn wrote: > > static int pause_prepare_data(const struct ethnl_req_info *req_base, > > @@ -34,10 +36,17 @@ static int pause_prepare_data(const struct > > ethnl_req_info *req_base, > > > > if (!dev->ethtool_ops->get_pauseparam) > > retu

Re: [PATCH net-next v2 1/8] ethtool: add standard pause stats

2020-09-13 Thread Andrew Lunn
> static int pause_prepare_data(const struct ethnl_req_info *req_base, > @@ -34,10 +36,17 @@ static int pause_prepare_data(const struct ethnl_req_info > *req_base, > > if (!dev->ethtool_ops->get_pauseparam) > return -EOPNOTSUPP; > + > ret = ethnl_ops_begin(dev); >

[PATCH net-next v2 1/8] ethtool: add standard pause stats

2020-09-11 Thread Jakub Kicinski
Currently drivers have to report their pause frames statistics via ethtool -S, and there is a wide variety of names used for these statistics. Add the two statistics defined in IEEE 802.3x to the standard API. Create a new ethtool request header flag for including statistics in the response to GET