Re: [PATCH net-next v2 1/3] net: phy: remove calls to genphy_config_init

2019-08-17 Thread Heiner Kallweit
On 16.08.2019 23:58, Florian Fainelli wrote: > On 8/16/19 1:31 PM, Heiner Kallweit wrote: >> Supported PHY features are either auto-detected or explicitly set. >> In both cases calling genphy_config_init isn't needed. All that >> genphy_config_init does is removing features that are set as >> suppo

Re: [PATCH net-next v2 1/3] net: phy: remove calls to genphy_config_init

2019-08-16 Thread Florian Fainelli
On 8/16/19 1:31 PM, Heiner Kallweit wrote: > Supported PHY features are either auto-detected or explicitly set. > In both cases calling genphy_config_init isn't needed. All that > genphy_config_init does is removing features that are set as > supported but can't be auto-detected. Basically it dupli

[PATCH net-next v2 1/3] net: phy: remove calls to genphy_config_init

2019-08-16 Thread Heiner Kallweit
Supported PHY features are either auto-detected or explicitly set. In both cases calling genphy_config_init isn't needed. All that genphy_config_init does is removing features that are set as supported but can't be auto-detected. Basically it duplicates the code in genphy_read_abilities. Therefore