Re: [PATCH net-next v2 1/3] cxgb4: add mirror action to TC-MATCHALL offload

2020-06-29 Thread Jakub Kicinski
On Tue, 30 Jun 2020 04:19:51 +0530 Rahul Lakkireddy wrote: > + if (refcount_read(&pi->vi_mirror_refcnt) > 1) { > + refcount_dec(&pi->vi_mirror_refcnt); > + goto out_unlock; > + } Please remove the use of refcount_t if you're doing this, otherwise a person looking at

[PATCH net-next v2 1/3] cxgb4: add mirror action to TC-MATCHALL offload

2020-06-29 Thread Rahul Lakkireddy
Add mirror Virtual Interface (VI) support to receive all ingress mirror traffic from the underlying device. The mirror VI is created dynamically, if the TC-MATCHALL rule has a corresponding mirror action. Also request MSI-X vectors needed for the mirror VI Rxqs. If no vectors are available, then di