Re: [PATCH net-next v2 07/12] gtp: use ephemeral source port

2020-12-12 Thread Jonas Bonn
Hi Harald, On 12/12/2020 11:07, Harald Welte wrote: Hi Jonas, On Fri, Dec 11, 2020 at 01:26:07PM +0100, Jonas Bonn wrote: From 3GPP TS 29.281: "...the UDP Source Port or the Flow Label field... should be set dynamically by the sending GTP-U entity to help balancing the load in the transport n

Re: [PATCH net-next v2 07/12] gtp: use ephemeral source port

2020-12-12 Thread Jonas Bonn
On 12/12/2020 06:35, Pravin Shelar wrote: On Fri, Dec 11, 2020 at 4:29 AM Jonas Bonn wrote: /* Read the IP destination address and resolve the PDP context. @@ -527,6 +527,10 @@ static int gtp_xmit_ip4(struct sk_buff *skb, struct net_device *dev) return -EMSGSIZE;

Re: [PATCH net-next v2 07/12] gtp: use ephemeral source port

2020-12-12 Thread Harald Welte
Hi Jonas, On Fri, Dec 11, 2020 at 01:26:07PM +0100, Jonas Bonn wrote: > From 3GPP TS 29.281: > "...the UDP Source Port or the Flow Label field... should be set dynamically > by the sending GTP-U entity to help balancing the load in the transport > network." You unfortuantely didn't specifiy which

Re: [PATCH net-next v2 07/12] gtp: use ephemeral source port

2020-12-11 Thread Pravin Shelar
On Fri, Dec 11, 2020 at 4:29 AM Jonas Bonn wrote: > > All GTP traffic is currently sent from the same source port. This makes > everything look like one big flow which is difficult to balance across > network resources. > > From 3GPP TS 29.281: > "...the UDP Source Port or the Flow Label field...

[PATCH net-next v2 07/12] gtp: use ephemeral source port

2020-12-11 Thread Jonas Bonn
All GTP traffic is currently sent from the same source port. This makes everything look like one big flow which is difficult to balance across network resources. >From 3GPP TS 29.281: "...the UDP Source Port or the Flow Label field... should be set dynamically by the sending GTP-U entity to help