Re: [PATCH net-next v2 07/10] r8169: migrate speed_down function to phylib

2018-07-10 Thread Andrew Lunn
On Tue, Jul 10, 2018 at 11:26:13PM +0200, Heiner Kallweit wrote: > On 10.07.2018 22:44, Andrew Lunn wrote: > >> static void rtl_speed_down(struct rtl8169_private *tp) > >> { > >> - u32 adv; > >> - int lpa; > >> + struct phy_device *phydev = tp->dev->phydev; > >> + u32 adv = phydev->lp_adverti

Re: [PATCH net-next v2 07/10] r8169: migrate speed_down function to phylib

2018-07-10 Thread Heiner Kallweit
On 10.07.2018 22:44, Andrew Lunn wrote: >> static void rtl_speed_down(struct rtl8169_private *tp) >> { >> -u32 adv; >> -int lpa; >> +struct phy_device *phydev = tp->dev->phydev; >> +u32 adv = phydev->lp_advertising & phydev->supported; >> >> -rtl_writephy(tp, 0x1f, 0x);

Re: [PATCH net-next v2 07/10] r8169: migrate speed_down function to phylib

2018-07-10 Thread Andrew Lunn
> static void rtl_speed_down(struct rtl8169_private *tp) > { > - u32 adv; > - int lpa; > + struct phy_device *phydev = tp->dev->phydev; > + u32 adv = phydev->lp_advertising & phydev->supported; > > - rtl_writephy(tp, 0x1f, 0x); > - lpa = rtl_readphy(tp, MII_LPA); > +

[PATCH net-next v2 07/10] r8169: migrate speed_down function to phylib

2018-07-10 Thread Heiner Kallweit
Change rtl_speed_down() to use phylib. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 33 +--- 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index dee