Re: [PATCH net-next v2 01/16] l2tp: update sk_user_data while holding sk_callback_lock

2018-02-12 Thread Guillaume Nault
On Mon, Feb 12, 2018 at 10:11:05AM +, James Chapman wrote: > Since L2TP hooks on sockets opened by userspace using sk_user_data, we > may race with other socket families that attempt to use the same > socket. > > This problem was discovered by syzbot using AF_KCM. KCM has since been > modified

Re: [PATCH net-next v2 01/16] l2tp: update sk_user_data while holding sk_callback_lock

2018-02-12 Thread David Miller
From: James Chapman Date: Mon, 12 Feb 2018 10:11:05 + > Since L2TP hooks on sockets opened by userspace using sk_user_data, we > may race with other socket families that attempt to use the same > socket. > > This problem was discovered by syzbot using AF_KCM. KCM has since been > modified to

[PATCH net-next v2 01/16] l2tp: update sk_user_data while holding sk_callback_lock

2018-02-12 Thread James Chapman
Since L2TP hooks on sockets opened by userspace using sk_user_data, we may race with other socket families that attempt to use the same socket. This problem was discovered by syzbot using AF_KCM. KCM has since been modified to use only TCP sockets to avoid hitting this issue but we should prevent