Re: [PATCH net-next v2 01/12] bnxt_en: Refactor rx SKB function.

2017-02-02 Thread Michael Chan
On Thu, Feb 2, 2017 at 4:22 PM, Jakub Kicinski wrote: > On Thu, 2 Feb 2017 15:40:19 -0800, Michael Chan wrote: >> On Thu, Feb 2, 2017 at 2:56 PM, Jakub Kicinski wrote: >> > (b) why >> > do you encode the two parameters in a single u32? It's the seventh >> > parameter so it's going on the stack a

Re: [PATCH net-next v2 01/12] bnxt_en: Refactor rx SKB function.

2017-02-02 Thread Jakub Kicinski
On Thu, 2 Feb 2017 15:40:19 -0800, Michael Chan wrote: > On Thu, Feb 2, 2017 at 2:56 PM, Jakub Kicinski wrote: > > On Thu, 2 Feb 2017 11:55:29 -0500, Michael Chan wrote: > >> @@ -755,8 +757,8 @@ static void bnxt_reuse_rx_agg_bufs(struct bnxt_napi > >> *bnapi, u16 cp_cons, > >> > >> static str

Re: [PATCH net-next v2 01/12] bnxt_en: Refactor rx SKB function.

2017-02-02 Thread Michael Chan
On Thu, Feb 2, 2017 at 2:56 PM, Jakub Kicinski wrote: > On Thu, 2 Feb 2017 11:55:29 -0500, Michael Chan wrote: >> @@ -755,8 +757,8 @@ static void bnxt_reuse_rx_agg_bufs(struct bnxt_napi >> *bnapi, u16 cp_cons, >> >> static struct sk_buff *bnxt_rx_skb(struct bnxt *bp, >>

Re: [PATCH net-next v2 01/12] bnxt_en: Refactor rx SKB function.

2017-02-02 Thread Jakub Kicinski
On Thu, 2 Feb 2017 11:55:29 -0500, Michael Chan wrote: > @@ -755,8 +757,8 @@ static void bnxt_reuse_rx_agg_bufs(struct bnxt_napi > *bnapi, u16 cp_cons, > > static struct sk_buff *bnxt_rx_skb(struct bnxt *bp, > struct bnxt_rx_ring_info *rxr, u16 cons, > -

[PATCH net-next v2 01/12] bnxt_en: Refactor rx SKB function.

2017-02-02 Thread Michael Chan
Minor refactoring of bnxt_rx_skb() so that it can easily be replaced by a new function that handles packets in a single page. Also, use a function pointer bp->rx_skb_func() to switch to a new function when we add the new mode in the next patch. Add a new field data_ptr that points to the packet d