Re: [PATCH net-next v2 01/10] r8169: add basic phylib support

2018-07-10 Thread Heiner Kallweit
On 10.07.2018 21:10, Andrew Lunn wrote: >> +static int r8169_mdio_read_reg(struct mii_bus *mii_bus, int phyaddr, int >> phyreg) >> +{ >> +struct rtl8169_private *tp = mii_bus->priv; >> + >> +if (phyaddr > 0) >> +return -EINVAL; > > Please use ENODEV. > > The mdio bus is scann

Re: [PATCH net-next v2 01/10] r8169: add basic phylib support

2018-07-10 Thread Andrew Lunn
> +static int r8169_mdio_read_reg(struct mii_bus *mii_bus, int phyaddr, int > phyreg) > +{ > + struct rtl8169_private *tp = mii_bus->priv; > + > + if (phyaddr > 0) > + return -EINVAL; Please use ENODEV. The mdio bus is scanned for devices in __mdiobus_register(). If mdiobus_s

[PATCH net-next v2 01/10] r8169: add basic phylib support

2018-07-10 Thread Heiner Kallweit
Add basic phylib support to r8169. All now unneeded old PHY handling code will be removed in subsequent patches. Signed-off-by: Heiner Kallweit --- v2: - return error in mdio ops if phyaddr > 0 - advertise pause modes --- drivers/net/ethernet/realtek/Kconfig | 1 + drivers/net/ethernet/realtek