Re: [PATCH net-next v2] tcp: force cwnd at least 2 in tcp_cwnd_reduction

2018-06-29 Thread Lawrence Brakmo
On 6/28/18, 1:48 PM, "netdev-ow...@vger.kernel.org on behalf of Neal Cardwell" wrote: On Thu, Jun 28, 2018 at 4:20 PM Lawrence Brakmo wrote: > > I just looked at 4.18 traces and the behavior is as follows: > >Host A sends the last packets of the request > >Ho

Re: [PATCH net-next v2] tcp: force cwnd at least 2 in tcp_cwnd_reduction

2018-06-28 Thread Lawrence Brakmo
On 6/28/18, 1:48 PM, "netdev-ow...@vger.kernel.org on behalf of Neal Cardwell" wrote: On Thu, Jun 28, 2018 at 4:20 PM Lawrence Brakmo wrote: > > I just looked at 4.18 traces and the behavior is as follows: > >Host A sends the last packets of the request > >

Re: [PATCH net-next v2] tcp: force cwnd at least 2 in tcp_cwnd_reduction

2018-06-28 Thread Lawrence Brakmo
On 6/28/18, 1:48 PM, "netdev-ow...@vger.kernel.org on behalf of Neal Cardwell" wrote: On Thu, Jun 28, 2018 at 4:20 PM Lawrence Brakmo wrote: > > I just looked at 4.18 traces and the behavior is as follows: > >Host A sends the last packets of the request > >

Re: [PATCH net-next v2] tcp: force cwnd at least 2 in tcp_cwnd_reduction

2018-06-28 Thread Neal Cardwell
On Thu, Jun 28, 2018 at 4:20 PM Lawrence Brakmo wrote: > > I just looked at 4.18 traces and the behavior is as follows: > >Host A sends the last packets of the request > >Host B receives them, and the last packet is marked with congestion (CE) > >Host B sends ACKs for packets not marke

Re: [PATCH net-next v2] tcp: force cwnd at least 2 in tcp_cwnd_reduction

2018-06-27 Thread Yuchung Cheng
, Eric Dumazet > , Wei Wang > Subject: Re: [PATCH net-next v2] tcp: force cwnd at least 2 in > tcp_cwnd_reduction > > > > On Wed, Jun 27, 2018 at 8:24 AM, Neal Cardwell wrote: > > On Tue, Jun 26, 2018 at 10:34 PM Lawrence Brakmo wrote: > > The only issue is if it

Re: [PATCH net-next v2] tcp: force cwnd at least 2 in tcp_cwnd_reduction

2018-06-27 Thread Yuchung Cheng
On Wed, Jun 27, 2018 at 8:24 AM, Neal Cardwell wrote: > On Tue, Jun 26, 2018 at 10:34 PM Lawrence Brakmo wrote: >> The only issue is if it is safe to always use 2 or if it is better to >> use min(2, snd_ssthresh) (which could still trigger the problem). > > Always using 2 SGTM. I don't think we n

Re: [PATCH net-next v2] tcp: force cwnd at least 2 in tcp_cwnd_reduction

2018-06-27 Thread Neal Cardwell
On Tue, Jun 26, 2018 at 10:34 PM Lawrence Brakmo wrote: > The only issue is if it is safe to always use 2 or if it is better to > use min(2, snd_ssthresh) (which could still trigger the problem). Always using 2 SGTM. I don't think we need min(2, snd_ssthresh), as that should be the same as just 2

Re: [PATCH net-next v2] tcp: force cwnd at least 2 in tcp_cwnd_reduction

2018-06-27 Thread Eric Dumazet
On 06/27/2018 08:04 AM, Eric Dumazet wrote: > > > On 06/26/2018 07:34 PM, Lawrence Brakmo wrote: >> When using dctcp and doing RPCs, if the last packet of a request is >> ECN marked as having seen congestion (CE), the sender can decrease its >> cwnd to 1. As a result, it will only send one pac

Re: [PATCH net-next v2] tcp: force cwnd at least 2 in tcp_cwnd_reduction

2018-06-27 Thread Eric Dumazet
On 06/26/2018 07:34 PM, Lawrence Brakmo wrote: > When using dctcp and doing RPCs, if the last packet of a request is > ECN marked as having seen congestion (CE), the sender can decrease its > cwnd to 1. As a result, it will only send one packet when a new request > is sent. In some instances thi

[PATCH net-next v2] tcp: force cwnd at least 2 in tcp_cwnd_reduction

2018-06-26 Thread Lawrence Brakmo
When using dctcp and doing RPCs, if the last packet of a request is ECN marked as having seen congestion (CE), the sender can decrease its cwnd to 1. As a result, it will only send one packet when a new request is sent. In some instances this results in high tail latencies. For example, in one set