Re: [PATCH net-next v2] net: core: decouple ifalias get/set from rtnl lock

2017-10-02 Thread Eric Dumazet
On Mon, 2017-10-02 at 17:09 +0200, Florian Westphal wrote: > Eric Dumazet wrote: > > Just use RCU : A writer is supposed to work on a private copy, and > > _then_ publish the new pointer, so that a reader can not see mangled > > string. > > > > We either copy the 'old' name or the 'new' one. > >

Re: [PATCH net-next v2] net: core: decouple ifalias get/set from rtnl lock

2017-10-02 Thread Florian Westphal
Eric Dumazet wrote: > Just use RCU : A writer is supposed to work on a private copy, and > _then_ publish the new pointer, so that a reader can not see mangled > string. > > We either copy the 'old' name or the 'new' one. > > A seqcount is not needed, and wont prevent you from reading the value

Re: [PATCH net-next v2] net: core: decouple ifalias get/set from rtnl lock

2017-10-02 Thread Eric Dumazet
On Mon, 2017-10-02 at 12:27 +0200, Florian Westphal wrote: > Device alias can be set by either rtnetlink (rtnl is held) or sysfs. > > rtnetlink hold the rtnl mutex, sysfs acquires it for this purpose. > Add an extra mutex for it plus a seqcount to get a consistent snapshot > of the alias buffer.

[PATCH net-next v2] net: core: decouple ifalias get/set from rtnl lock

2017-10-02 Thread Florian Westphal
Device alias can be set by either rtnetlink (rtnl is held) or sysfs. rtnetlink hold the rtnl mutex, sysfs acquires it for this purpose. Add an extra mutex for it plus a seqcount to get a consistent snapshot of the alias buffer. This allows the sysfs path to not take rtnl and would later allow to