Re: [PATCH net-next v2] net: Add table id from route lookup to route response

2015-09-02 Thread Stephen Hemminger
On Wed, 2 Sep 2015 13:16:20 -0700 David Ahern wrote: > diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h > index 702024769c74..5add1468350a 100644 > --- a/include/uapi/linux/rtnetlink.h > +++ b/include/uapi/linux/rtnetlink.h > @@ -310,6 +310,7 @@ enum rtattr_type_t { >

Re: [PATCH net-next v2] net: Add table id from route lookup to route response

2015-09-02 Thread David Ahern
On 9/2/15 2:41 PM, Alexander Duyck wrote: Why not implement this this same for IPv4 and IPv6? It looks like it is only included if it is non-zer and not MAIN in the above case, and then below as long as a table ID is non-zero you are setting the value. Why not just include the value in all cas

Re: [PATCH net-next v2] net: Add table id from route lookup to route response

2015-09-02 Thread Alexander Duyck
On 09/02/2015 01:16 PM, David Ahern wrote: IPv4 ABI has the table hardcoded as RT_TABLE_MAIN regardless of the table hit for the route lookup. Add the table using a new attribute, RTA_TABLE_LOOKUP, to maintain the ABI yet return the right table id. Signed-off-by: David Ahern --- Thomas: Someth

Re: [PATCH net-next v2] net: Add table id from route lookup to route response

2015-09-02 Thread David Ahern
On 9/2/15 2:23 PM, Thomas Graf wrote: On 09/02/15 at 01:16pm, David Ahern wrote: IPv4 ABI has the table hardcoded as RT_TABLE_MAIN regardless of the table hit for the route lookup. Add the table using a new attribute, RTA_TABLE_LOOKUP, to maintain the ABI yet return the right table id. Signed-o

Re: [PATCH net-next v2] net: Add table id from route lookup to route response

2015-09-02 Thread Thomas Graf
On 09/02/15 at 01:16pm, David Ahern wrote: > IPv4 ABI has the table hardcoded as RT_TABLE_MAIN regardless of the table > hit for the route lookup. Add the table using a new attribute, > RTA_TABLE_LOOKUP, to maintain the ABI yet return the right table id. > > Signed-off-by: David Ahern > --- > >

[PATCH net-next v2] net: Add table id from route lookup to route response

2015-09-02 Thread David Ahern
IPv4 ABI has the table hardcoded as RT_TABLE_MAIN regardless of the table hit for the route lookup. Add the table using a new attribute, RTA_TABLE_LOOKUP, to maintain the ABI yet return the right table id. Signed-off-by: David Ahern --- Thomas: Something like this? The current ABI is returning