On Wed, 4 Nov 2020 01:39:52 + Hayes Wang wrote:
> Jakub Kicinski
> > Sent: Wednesday, November 4, 2020 12:16 AM
> [...]
> > > So no, please do not create such a common file, it is not needed or a
> > > good idea.
> >
> > I wouldn't go that far, PCI subsystem just doesn't want everyone to
Jakub Kicinski
> Sent: Wednesday, November 4, 2020 12:16 AM
[...]
> > So no, please do not create such a common file, it is not needed or a
> > good idea.
>
> I wouldn't go that far, PCI subsystem just doesn't want everyone to add
> IDs to the shared file unless there is a reason.
>
> *Do n
On Tue, 3 Nov 2020 10:32:41 +0100 Greg Kroah-Hartman wrote:
> On Mon, Nov 02, 2020 at 11:47:18AM -0800, Jakub Kicinski wrote:
> > On Mon, 2 Nov 2020 07:20:15 + Hayes Wang wrote:
> > > Jakub Kicinski
> > > > Can you describe the use case in more detail?
> > > >
> > > > AFAICT r8152 defines
Greg Kroah-Hartman
> Sent: Tuesday, November 3, 2020 5:33 PM
[...]
> There is a reason, it's a nightmare to maintain and handle merges for,
> just don't do it.
>
> Read the comments at the top of the pci_ids.h file if you are curious
> why we don't even do this for PCI device ids anymore for the
On Mon, Nov 02, 2020 at 11:47:18AM -0800, Jakub Kicinski wrote:
> On Mon, 2 Nov 2020 07:20:15 + Hayes Wang wrote:
> > Jakub Kicinski
> > > Can you describe the use case in more detail?
> > >
> > > AFAICT r8152 defines a match for the exact same device.
> > > Does it not mean that which driver
On Mon, 2 Nov 2020 07:20:15 + Hayes Wang wrote:
> Jakub Kicinski
> > Can you describe the use case in more detail?
> >
> > AFAICT r8152 defines a match for the exact same device.
> > Does it not mean that which driver is used will be somewhat random
> > if both are built?
>
> I export rtl_
Jakub Kicinski
[...]
> Can you describe the use case in more detail?
>
> AFAICT r8152 defines a match for the exact same device.
> Does it not mean that which driver is used will be somewhat random
> if both are built?
I export rtl_get_version() from r8152. It would return none zero
value if r81
On Fri, 30 Oct 2020 11:23:08 +0800 Hayes Wang wrote:
> Support ECM mode based on cdc_ether with relative mii functions,
> when CONFIG_USB_RTL8152 is not set, or the device is not supported
> by r8152 driver.
>
> Signed-off-by: Hayes Wang
Can you describe the use case in more detail?
AFAICT r815
Support ECM mode based on cdc_ether with relative mii functions,
when CONFIG_USB_RTL8152 is not set, or the device is not supported
by r8152 driver.
Signed-off-by: Hayes Wang
---
v2:
Add include/linux/usb/r8152.h to avoid the warning about
no previous prototype for rtl8152_get_version.
drivers/