Re: [PATCH net-next v2] ipv6: sr: fix IPv6 initialization failure without lwtunnels

2016-11-16 Thread David Miller
From: Roopa Prabhu Date: Wed, 16 Nov 2016 07:49:19 -0800 > On 11/15/16, 7:18 AM, David Miller wrote: >> Although I'd like to entertain the idea of making LWTUNNEL >> unconditionally built and considered a fundamental piece of >> networking infrastructure just like net/core/dst.c > ok, ack. I can

Re: [PATCH net-next v2] ipv6: sr: fix IPv6 initialization failure without lwtunnels

2016-11-16 Thread Roopa Prabhu
On 11/15/16, 7:18 AM, David Miller wrote: > From: David Lebrun > Date: Tue, 15 Nov 2016 11:17:20 +0100 > >> On 11/14/2016 03:22 PM, Roopa Prabhu wrote: >>> I prefer option b). most LWTUNNEL encaps are done this way. >>> >>> seg6 and seg6_iptunnel is new segment routing code and can be under >>> CO

Re: [PATCH net-next v2] ipv6: sr: fix IPv6 initialization failure without lwtunnels

2016-11-15 Thread David Miller
From: David Lebrun Date: Tue, 15 Nov 2016 11:17:20 +0100 > On 11/14/2016 03:22 PM, Roopa Prabhu wrote: >> I prefer option b). most LWTUNNEL encaps are done this way. >> >> seg6 and seg6_iptunnel is new segment routing code and can be under >> CONFIG_IPV6_SEG6 which depends on CONFIG_LWTUNNEL and

Re: [PATCH net-next v2] ipv6: sr: fix IPv6 initialization failure without lwtunnels

2016-11-15 Thread David Lebrun
On 11/14/2016 03:22 PM, Roopa Prabhu wrote: > I prefer option b). most LWTUNNEL encaps are done this way. > > seg6 and seg6_iptunnel is new segment routing code and can be under > CONFIG_IPV6_SEG6 which depends on CONFIG_LWTUNNEL and CONFIG_IPV6. > CONFIG_IPV6_SEG6_HMAC could then depend on CONFIG

Re: [PATCH net-next v2] ipv6: sr: fix IPv6 initialization failure without lwtunnels

2016-11-14 Thread Roopa Prabhu
On 11/13/16, 11:59 AM, David Lebrun wrote: > On 11/13/2016 06:23 AM, David Miller wrote: >> This seems like such a huge mess, quite frankly. >> >> IPV6-SR has so many strange dependencies, a weird Kconfig option that is >> simply controlling what a responsible sysadmin should be allow to do if >> h

Re: [PATCH net-next v2] ipv6: sr: fix IPv6 initialization failure without lwtunnels

2016-11-13 Thread David Lebrun
On 11/13/2016 06:23 AM, David Miller wrote: > This seems like such a huge mess, quite frankly. > > IPV6-SR has so many strange dependencies, a weird Kconfig option that is > simply controlling what a responsible sysadmin should be allow to do if > he chooses anyways. > > Every distribution is goi

Re: [PATCH net-next v2] ipv6: sr: fix IPv6 initialization failure without lwtunnels

2016-11-12 Thread David Miller
From: David Miller Date: Sun, 13 Nov 2016 00:20:55 -0500 (EST) > From: David Lebrun > Date: Thu, 10 Nov 2016 13:26:53 +0100 > >> v2: fix conditional compilation for seg6_iptunnel.o in Makefile >> >> This patch compiles SR lwtunnels support only if CONFIG_LWTUNNEL=y. >> >> If IPv6 is enabled a

Re: [PATCH net-next v2] ipv6: sr: fix IPv6 initialization failure without lwtunnels

2016-11-12 Thread David Miller
From: David Lebrun Date: Thu, 10 Nov 2016 13:26:53 +0100 > v2: fix conditional compilation for seg6_iptunnel.o in Makefile > > This patch compiles SR lwtunnels support only if CONFIG_LWTUNNEL=y. > > If IPv6 is enabled and CONFIG_LWTUNNEL=n, then seg6_iptunnel_init() > fails with EOPNOTSUPP whic

[PATCH net-next v2] ipv6: sr: fix IPv6 initialization failure without lwtunnels

2016-11-10 Thread David Lebrun
v2: fix conditional compilation for seg6_iptunnel.o in Makefile This patch compiles SR lwtunnels support only if CONFIG_LWTUNNEL=y. If IPv6 is enabled and CONFIG_LWTUNNEL=n, then seg6_iptunnel_init() fails with EOPNOTSUPP which in turn makes seg6_init() fail, blocking the IPv6 initialization, wit