Re: [PATCH net-next v2] ipv6: fix multipath route replace error recovery

2015-09-08 Thread Nicolas Dichtel
Le 08/09/2015 02:01, roopa a écrit : On 9/7/15, 5:03 AM, Nicolas Dichtel wrote: [snip] yes, i had submitted the patch you mention above to fix a slightly different problem that existed then..which was introduced by "51ebd3181572 ("ipv6: add support of equal cost multipath (ECMP)")". Commit "35f

Re: [PATCH net-next v2] ipv6: fix multipath route replace error recovery

2015-09-07 Thread roopa
On 9/7/15, 5:03 AM, Nicolas Dichtel wrote: The bug you're trying to fix has been introduced by the commit 51ebd3181572 ("ipv6: add support of equal cost multipath (ECMP)"). Commit 27596472473a ("ipv6: fix ECMP route replacement") didn't try to fix this problem. The reason I say "27596472473a (

Re: [PATCH net-next v2] ipv6: fix multipath route replace error recovery

2015-09-07 Thread Nicolas Dichtel
+ Michal Kubecek Le 06/09/2015 22:46, roopa a écrit : On 9/4/15, 1:12 AM, Nicolas Dichtel wrote: Le 03/09/2015 01:44, Roopa Prabhu a écrit : [snip] Fixes: 4a287eba2de3 ("IPv6 routing, NLM_F_* flag support: REPLACE and EXCL flags support, warn about missing CREATE flag") ECMP was added one ye

Re: [PATCH net-next v2] ipv6: fix multipath route replace error recovery

2015-09-06 Thread roopa
On 9/4/15, 1:12 AM, Nicolas Dichtel wrote: Le 03/09/2015 01:44, Roopa Prabhu a écrit : From: Roopa Prabhu Problem: The ecmp route replace support for ipv6 in the kernel, deletes the existing ecmp route too early, ie when it installs the first nexthop. If there is an error in installing the sub

Re: [PATCH net-next v2] ipv6: fix multipath route replace error recovery

2015-09-04 Thread Nicolas Dichtel
Le 03/09/2015 01:44, Roopa Prabhu a écrit : From: Roopa Prabhu Problem: The ecmp route replace support for ipv6 in the kernel, deletes the existing ecmp route too early, ie when it installs the first nexthop. If there is an error in installing the subsequent nexthops, its too late to recover th

[PATCH net-next v2] ipv6: fix multipath route replace error recovery

2015-09-02 Thread Roopa Prabhu
From: Roopa Prabhu Problem: The ecmp route replace support for ipv6 in the kernel, deletes the existing ecmp route too early, ie when it installs the first nexthop. If there is an error in installing the subsequent nexthops, its too late to recover the already deleted existing route This patch f