Re: [PATCH net-next v2] dsa:mv88e6xxx: dispose irq mapping for chip->irq

2016-12-09 Thread Andrew Lunn
On Wed, Dec 07, 2016 at 05:40:12PM +0100, Volodymyr Bendiuga wrote: > Yes, most of the users of of_irq_get() do not use irq_dispose_mapping(). > > But some of them do (some irq chips), and I believe the correct way > of doing this is to > > dispose irq mapping, as the description for this functio

Re: [PATCH net-next v2] dsa:mv88e6xxx: dispose irq mapping for chip->irq

2016-12-07 Thread Volodymyr Bendiuga
Yes, most of the users of of_irq_get() do not use irq_dispose_mapping(). But some of them do (some irq chips), and I believe the correct way of doing this is to dispose irq mapping, as the description for this function says that it unmaps the irq, which is mapped by of_irq_parse_and_map().

Re: [PATCH net-next v2] dsa:mv88e6xxx: dispose irq mapping for chip->irq

2016-12-07 Thread Andrew Lunn
On Wed, Dec 07, 2016 at 11:35:07AM +0100, Volodymyr Bendiuga wrote: > Signed-off-by: Volodymyr Bendiuga You need some text in the Change log. Say why this change is needed, etc. Looking through other users of of_irq_get(), i don't see any disposing of the mapping. It is not obvious you need to d