Re: [PATCH net-next v15] openvswitch: enable NSH support

2017-11-07 Thread Yang, Yi
On Tue, Nov 07, 2017 at 05:01:28AM -0800, Pravin Shelar wrote: > On Tue, Nov 7, 2017 at 3:55 AM, Yang, Yi wrote: > > On Tue, Nov 07, 2017 at 03:58:35AM -0800, Pravin Shelar wrote: > >> On Tue, Nov 7, 2017 at 3:28 AM, Yang, Yi wrote: > >> > On Tue, Nov 07, 2017 at 06:57:30PM +0800, Pravin Shelar w

Re: [PATCH net-next v15] openvswitch: enable NSH support

2017-11-07 Thread Pravin Shelar
On Tue, Nov 7, 2017 at 3:55 AM, Yang, Yi wrote: > On Tue, Nov 07, 2017 at 03:58:35AM -0800, Pravin Shelar wrote: >> On Tue, Nov 7, 2017 at 3:28 AM, Yang, Yi wrote: >> > On Tue, Nov 07, 2017 at 06:57:30PM +0800, Pravin Shelar wrote: >> >> On Mon, Nov 6, 2017 at 4:22 AM, Jiri Benc wrote: >> >> > O

Re: [PATCH net-next v15] openvswitch: enable NSH support

2017-11-07 Thread Yang, Yi
On Tue, Nov 07, 2017 at 03:58:35AM -0800, Pravin Shelar wrote: > On Tue, Nov 7, 2017 at 3:28 AM, Yang, Yi wrote: > > On Tue, Nov 07, 2017 at 06:57:30PM +0800, Pravin Shelar wrote: > >> On Mon, Nov 6, 2017 at 4:22 AM, Jiri Benc wrote: > >> > On Sat, 4 Nov 2017 07:29:46 -0700, Pravin Shelar wrote:

Re: [PATCH net-next v15] openvswitch: enable NSH support

2017-11-07 Thread Pravin Shelar
On Tue, Nov 7, 2017 at 3:28 AM, Yang, Yi wrote: > On Tue, Nov 07, 2017 at 06:57:30PM +0800, Pravin Shelar wrote: >> On Mon, Nov 6, 2017 at 4:22 AM, Jiri Benc wrote: >> > On Sat, 4 Nov 2017 07:29:46 -0700, Pravin Shelar wrote: >> >> > +int nsh_push(struct sk_buff *skb, const struct nshhdr *pushed_

Re: [PATCH net-next v15] openvswitch: enable NSH support

2017-11-07 Thread Yang, Yi
On Tue, Nov 07, 2017 at 06:57:30PM +0800, Pravin Shelar wrote: > On Mon, Nov 6, 2017 at 4:22 AM, Jiri Benc wrote: > > On Sat, 4 Nov 2017 07:29:46 -0700, Pravin Shelar wrote: > >> > +int nsh_push(struct sk_buff *skb, const struct nshhdr *pushed_nh) > >> > +{ > >> > + struct nshhdr *nh; > >> >

Re: [PATCH net-next v15] openvswitch: enable NSH support

2017-11-07 Thread Pravin Shelar
On Mon, Nov 6, 2017 at 4:22 AM, Jiri Benc wrote: > On Sat, 4 Nov 2017 07:29:46 -0700, Pravin Shelar wrote: >> > +int nsh_push(struct sk_buff *skb, const struct nshhdr *pushed_nh) >> > +{ >> > + struct nshhdr *nh; >> > + size_t length = nsh_hdr_len(pushed_nh); >> > + u8 next_proto

Re: [PATCH net-next v15] openvswitch: enable NSH support

2017-11-06 Thread Jiri Benc
On Sat, 4 Nov 2017 07:29:46 -0700, Pravin Shelar wrote: > > +int nsh_push(struct sk_buff *skb, const struct nshhdr *pushed_nh) > > +{ > > + struct nshhdr *nh; > > + size_t length = nsh_hdr_len(pushed_nh); > > + u8 next_proto; > > + > > + if (skb->mac_len) { > > +

Re: [PATCH net-next v15] openvswitch: enable NSH support

2017-11-06 Thread Pravin Shelar
On Sun, Nov 5, 2017 at 8:19 PM, Yang, Yi wrote: > On Sat, Nov 04, 2017 at 10:29:46PM +0800, Pravin Shelar wrote: >> On Tue, Oct 31, 2017 at 9:03 PM, Yi Yang wrote: >> > +int nsh_push(struct sk_buff *skb, const struct nshhdr *pushed_nh) >> > +{ >> > + struct nshhdr *nh; >> > + size_t l

Re: [PATCH net-next v15] openvswitch: enable NSH support

2017-11-05 Thread Yang, Yi
On Sat, Nov 04, 2017 at 10:29:46PM +0800, Pravin Shelar wrote: > On Tue, Oct 31, 2017 at 9:03 PM, Yi Yang wrote: > > +int nsh_push(struct sk_buff *skb, const struct nshhdr *pushed_nh) > > +{ > > + struct nshhdr *nh; > > + size_t length = nsh_hdr_len(pushed_nh); > > + u8 next_prot

Re: [PATCH net-next v15] openvswitch: enable NSH support

2017-11-04 Thread Pravin Shelar
On Tue, Oct 31, 2017 at 9:03 PM, Yi Yang wrote: > v14->v15 > - Check size in nsh_hdr_from_nlattr > - Fixed four small issues pointed out By Jiri and Eric > > v13->v14 > - Rename skb_push_nsh to nsh_push per Dave's comment > - Rename skb_pop_nsh to nsh_pop per Dave's comment > > v12->v13 > - F

Re: [PATCH net-next v15] openvswitch: enable NSH support

2017-11-04 Thread Pravin Shelar
On Thu, Nov 2, 2017 at 6:40 PM, Yang, Yi wrote: > On Thu, Nov 02, 2017 at 05:06:47AM -0700, Pravin Shelar wrote: >> On Wed, Nov 1, 2017 at 7:50 PM, Yang, Yi wrote: >> > On Thu, Nov 02, 2017 at 08:52:40AM +0800, Pravin Shelar wrote: >> >> On Tue, Oct 31, 2017 at 9:03 PM, Yi Yang wrote: >> >> > >>

Re: [PATCH net-next v15] openvswitch: enable NSH support

2017-11-02 Thread Yang, Yi
On Thu, Nov 02, 2017 at 05:06:47AM -0700, Pravin Shelar wrote: > On Wed, Nov 1, 2017 at 7:50 PM, Yang, Yi wrote: > > On Thu, Nov 02, 2017 at 08:52:40AM +0800, Pravin Shelar wrote: > >> On Tue, Oct 31, 2017 at 9:03 PM, Yi Yang wrote: > >> > > >> > OVS master and 2.8 branch has merged NSH userspace

Re: [PATCH net-next v15] openvswitch: enable NSH support

2017-11-02 Thread Yang, Yi
On Thu, Nov 02, 2017 at 05:06:47AM -0700, Pravin Shelar wrote: > On Wed, Nov 1, 2017 at 7:50 PM, Yang, Yi wrote: > > On Thu, Nov 02, 2017 at 08:52:40AM +0800, Pravin Shelar wrote: > >> On Tue, Oct 31, 2017 at 9:03 PM, Yi Yang wrote: > >> > > >> > OVS master and 2.8 branch has merged NSH userspace

Re: [PATCH net-next v15] openvswitch: enable NSH support

2017-11-02 Thread Pravin Shelar
On Wed, Nov 1, 2017 at 7:50 PM, Yang, Yi wrote: > On Thu, Nov 02, 2017 at 08:52:40AM +0800, Pravin Shelar wrote: >> On Tue, Oct 31, 2017 at 9:03 PM, Yi Yang wrote: >> > >> > OVS master and 2.8 branch has merged NSH userspace >> > patch series, this patch is to enable NSH support >> > in kernel da

Re: [PATCH net-next v15] openvswitch: enable NSH support

2017-11-01 Thread Yang, Yi
On Thu, Nov 02, 2017 at 08:52:40AM +0800, Pravin Shelar wrote: > On Tue, Oct 31, 2017 at 9:03 PM, Yi Yang wrote: > > > > OVS master and 2.8 branch has merged NSH userspace > > patch series, this patch is to enable NSH support > > in kernel data path in order that OVS can support > > NSH in compat

Re: [PATCH net-next v15] openvswitch: enable NSH support

2017-11-01 Thread Pravin Shelar
On Tue, Oct 31, 2017 at 9:03 PM, Yi Yang wrote: > v14->v15 > - Check size in nsh_hdr_from_nlattr > - Fixed four small issues pointed out By Jiri and Eric > > v13->v14 > - Rename skb_push_nsh to nsh_push per Dave's comment > - Rename skb_pop_nsh to nsh_pop per Dave's comment > > v12->v13 > - F

Re: [PATCH net-next v15] openvswitch: enable NSH support

2017-11-01 Thread Eric Garver
On Wed, Nov 01, 2017 at 12:03:01PM +0800, Yi Yang wrote: > v14->v15 > - Check size in nsh_hdr_from_nlattr > - Fixed four small issues pointed out By Jiri and Eric Thanks Yi. Acked-by: Eric Garver

Re: [PATCH net-next v15] openvswitch: enable NSH support

2017-11-01 Thread Jiri Benc
On Wed, 1 Nov 2017 12:03:01 +0800, Yi Yang wrote: > v14->v15 > - Check size in nsh_hdr_from_nlattr > - Fixed four small issues pointed out By Jiri and Eric Acked-by: Jiri Benc

[PATCH net-next v15] openvswitch: enable NSH support

2017-10-31 Thread Yi Yang
v14->v15 - Check size in nsh_hdr_from_nlattr - Fixed four small issues pointed out By Jiri and Eric v13->v14 - Rename skb_push_nsh to nsh_push per Dave's comment - Rename skb_pop_nsh to nsh_pop per Dave's comment v12->v13 - Fix NSH header length check in set_nsh v11->v12 - Fix missing chan