Re: [PATCH net-next v1] ptp: document struct ptp_clock_request members

2020-11-18 Thread Jacob Keller
On 11/17/2020 1:38 PM, Ahmad Fatoum wrote: > It's arguable most people interested in configuring a PPS signal > want it as external output, not as kernel input. PTP_CLK_REQ_PPS > is for input though. Add documentation to nudge readers into > the correct direction. Agreed. I think at least one d

Re: [PATCH net-next v1] ptp: document struct ptp_clock_request members

2020-11-18 Thread Jakub Kicinski
On Wed, 18 Nov 2020 05:05:41 -0800 Richard Cochran wrote: > On Tue, Nov 17, 2020 at 10:38:26PM +0100, Ahmad Fatoum wrote: > > It's arguable most people interested in configuring a PPS signal > > want it as external output, not as kernel input. PTP_CLK_REQ_PPS > > is for input though. Add documentat

Re: [PATCH net-next v1] ptp: document struct ptp_clock_request members

2020-11-18 Thread Richard Cochran
On Tue, Nov 17, 2020 at 10:38:26PM +0100, Ahmad Fatoum wrote: > It's arguable most people interested in configuring a PPS signal > want it as external output, not as kernel input. PTP_CLK_REQ_PPS > is for input though. Add documentation to nudge readers into > the correct direction. > > Signed-off

[PATCH net-next v1] ptp: document struct ptp_clock_request members

2020-11-17 Thread Ahmad Fatoum
It's arguable most people interested in configuring a PPS signal want it as external output, not as kernel input. PTP_CLK_REQ_PPS is for input though. Add documentation to nudge readers into the correct direction. Signed-off-by: Ahmad Fatoum --- Prompted by Richard's comment here: https://lore.ke