Re: [PATCH net-next V2 00/16] net: fec: cleanup and fixes

2016-02-25 Thread Joshua Clayton
On Thu, 25 Feb 2016 09:05:34 -0700 Troy Kisky wrote: > On 2/24/2016 7:52 PM, Joshua Clayton wrote: > > Hello Troy, > > I'm replying here instead of to a particular commit because several > > of the commit messages seem inadequate. > > > > The first line summaries all look good. > > > > The desc

Re: [PATCH net-next V2 00/16] net: fec: cleanup and fixes

2016-02-25 Thread Troy Kisky
On 2/24/2016 7:52 PM, Joshua Clayton wrote: > Hello Troy, > I'm replying here instead of to a particular commit because several of > the commit messages seem inadequate. > > The first line summaries all look good. > > The descriptions should each also include the "user visible impact" of > the pa

Re: [PATCH net-next V2 00/16] net: fec: cleanup and fixes

2016-02-25 Thread Troy Kisky
On 2/25/2016 1:39 AM, Holger Schurig wrote: > Hi Troy, > > what is the general aim of your patches? Stability? Speed? Cleanup? > 1. Stability 2. performance 3. easier to read 4. more debug info The 2nd goal is very hard to measure. It seems function alignment changes swamp most any other im

Re: [PATCH net-next V2 00/16] net: fec: cleanup and fixes

2016-02-25 Thread Holger Schurig
Hi Troy, what is the general aim of your patches? Stability? Speed? Cleanup?

Re: [PATCH net-next V2 00/16] net: fec: cleanup and fixes

2016-02-24 Thread Joshua Clayton
Hello Troy, I'm replying here instead of to a particular commit because several of the commit messages seem inadequate. The first line summaries all look good. The descriptions should each also include the "user visible impact" of the patch and the justification for it (i.e. why you made the chan

[PATCH net-next V2 00/16] net: fec: cleanup and fixes

2016-02-24 Thread Troy Kisky
V2 is a rebase on top of johannes endian-safe patch and this set is only the next 16 patches. The testing for this series was done on a nitrogen6x. The base commit was commit f5461c27631672b9e95282812ee521c53f502eca Merge branch 'dsa-pass-bridge-to-drivers' Testing showed no change in performa