RE: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

2015-09-17 Thread KY Srinivasan
er...@vger.kernel.org; jasow...@redhat.com > Subject: Re: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V > > From: KY Srinivasan > Date: Thu, 17 Sep 2015 19:52:01 + > > > > > > >> -Original Message- > >> Have a pre-cooked ring

Re: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

2015-09-17 Thread David Miller
From: KY Srinivasan Date: Thu, 17 Sep 2015 19:52:01 + > > >> -Original Message- >> Have a pre-cooked ring of buffers for these descriptors that you can >> point the chip at. No per-packet allocation is necessary at all. > > Even if I had a ring of buffers, I would still need to ma

RE: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

2015-09-17 Thread KY Srinivasan
l.org; > linux-ker...@vger.kernel.org; jasow...@redhat.com > Subject: Re: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V > > From: KY Srinivasan > Date: Thu, 17 Sep 2015 15:14:05 + > > > I think I can achieve my original goal of not having any allocation > > in the s

Re: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

2015-09-17 Thread David Miller
From: KY Srinivasan Date: Thu, 17 Sep 2015 15:14:05 + > I think I can achieve my original goal of not having any allocation > in the send path by carefully using the memory available in the skb: Please stop flat-out ignoring David L.'s suggestion. Have a pre-cooked ring of buffers for these

RE: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

2015-09-17 Thread KY Srinivasan
nel.org; > Jason Wang > Subject: RE: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V > > From: KY Srinivasan > > Sent: 16 September 2015 23:58 > ... > > > I think we get that. The question is does the Remote NDIS header and > > > packet

Re: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

2015-09-17 Thread Vitaly Kuznetsov
David Miller writes: > From: David Laight > Date: Wed, 16 Sep 2015 16:25:03 + > >> Am I right in thinking this is adding an extra 96 unused bytes to the front >> of almost all skb just so that hyper-v can make its link level header >> contiguous with whatever follows (IP header ?). >> >> Do

RE: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

2015-09-17 Thread David Laight
From: KY Srinivasan > Sent: 16 September 2015 23:58 ... > > I think we get that. The question is does the Remote NDIS header and > > packet info actually need to be a part of the header data? I would > > argue that it probably doesn't. > > > > So for example in netvsc_start_xmit it looks like you

RE: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

2015-09-16 Thread KY Srinivasan
r.kernel.org; > Jason Wang > Subject: Re: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V > > On 09/16/2015 10:55 AM, KY Srinivasan wrote: > > > >> -Original Message- > >> From: David Laight [mailto:david.lai...@aculab.com] > >>

RE: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

2015-09-16 Thread KY Srinivasan
r.kernel.org; > Jason Wang > Subject: Re: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V > > On 09/16/2015 03:57 PM, KY Srinivasan wrote: > > > >> -Original Message- > >> From: Alexander Duyck [mailto:alexander.du...@gmail.com] > >>

Re: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

2015-09-16 Thread Alexander Duyck
-ker...@vger.kernel.org; Jason Wang Subject: Re: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V On 09/16/2015 10:55 AM, KY Srinivasan wrote: -Original Message- From: David Laight [mailto:david.lai...@aculab.com] Sent: Wednesday, September 16, 2015 9:25 AM To: Haiyang Zhang

Re: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

2015-09-16 Thread Alexander Duyck
Srinivasan ; Jason Wang Subject: RE: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper- V From: Haiyang Zhang Sent: 16 September 2015 17:09 -Original Message- From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] Sent: Wednesday, September 16, 2015 11:50 AM To: netdev@vger.kernel.org Cc

Re: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

2015-09-16 Thread David Miller
From: David Laight Date: Wed, 16 Sep 2015 16:25:03 + > Am I right in thinking this is adding an extra 96 unused bytes to the front > of almost all skb just so that hyper-v can make its link level header > contiguous with whatever follows (IP header ?). > > Doesn't sound ideal. Agreed, this

RE: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

2015-09-16 Thread KY Srinivasan
n Wang > Subject: RE: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper- > V > > From: Haiyang Zhang > > Sent: 16 September 2015 17:09 > > > -Original Message- > > > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > > > Sent: Wedne

Re: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

2015-09-16 Thread Alexander Duyck
...@vger.kernel.org; KY Srinivasan ; Haiyang Zhang ; Jason Wang Subject: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V Commit b08cc79155fc26d0d112b1470d1ece5034651a4b ("hv_netvsc: Eliminate memory allocation in the packet send path") introduced skb headroom request for Hyper-V net

RE: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

2015-09-16 Thread David Laight
ger.kernel.org; > > KY Srinivasan ; Haiyang Zhang > > ; Jason Wang > > Subject: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V > > > > Commit b08cc79155fc26d0d112b1470d1ece5034651a4b ("hv_netvsc: Eliminate > > memory allocation in the packet

RE: [PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

2015-09-16 Thread Haiyang Zhang
[PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V > > Commit b08cc79155fc26d0d112b1470d1ece5034651a4b ("hv_netvsc: Eliminate > memory allocation in the packet send path") introduced skb headroom > request for Hyper-V netvsc driver: > >

[PATCH net-next RFC] net: increase LL_MAX_HEADER for Hyper-V

2015-09-16 Thread Vitaly Kuznetsov
Commit b08cc79155fc26d0d112b1470d1ece5034651a4b ("hv_netvsc: Eliminate memory allocation in the packet send path") introduced skb headroom request for Hyper-V netvsc driver: max_needed_headroom = sizeof(struct hv_netvsc_packet) + sizeof(struct rndis_message)