Re: [PATCH net-next 7/8] mld: convert ip6_sf_socklist to list macros

2021-02-08 Thread Taehee Yoo
On Tue, 9 Feb 2021 at 11:56, Jakub Kicinski wrote: > > On Mon, 8 Feb 2021 19:18:40 -0700 David Ahern wrote: > > On 2/8/21 7:05 PM, Taehee Yoo wrote: > > > Thanks, I understand why the arrays have been using. > > > I will send a v2 patch, which contains only the necessary changes. > > > > please se

Re: [PATCH net-next 7/8] mld: convert ip6_sf_socklist to list macros

2021-02-08 Thread Jakub Kicinski
On Mon, 8 Feb 2021 19:18:40 -0700 David Ahern wrote: > On 2/8/21 7:05 PM, Taehee Yoo wrote: > > Thanks, I understand why the arrays have been using. > > I will send a v2 patch, which contains only the necessary changes. > > please send v2 as a patch series and not 8 individual patches + cover >

Re: [PATCH net-next 7/8] mld: convert ip6_sf_socklist to list macros

2021-02-08 Thread Taehee Yoo
On Tue, 9 Feb 2021 at 11:18, David Ahern wrote: > > On 2/8/21 7:05 PM, Taehee Yoo wrote: > > Thanks, I understand why the arrays have been using. > > I will send a v2 patch, which contains only the necessary changes. > > please send v2 as a patch series and not 8 individual patches + cover > lette

Re: [PATCH net-next 7/8] mld: convert ip6_sf_socklist to list macros

2021-02-08 Thread David Ahern
On 2/8/21 7:05 PM, Taehee Yoo wrote: > Thanks, I understand why the arrays have been using. > I will send a v2 patch, which contains only the necessary changes. please send v2 as a patch series and not 8 individual patches + cover letter. Thanks,

Re: [PATCH net-next 7/8] mld: convert ip6_sf_socklist to list macros

2021-02-08 Thread Taehee Yoo
On Tue, 9 Feb 2021 at 03:31, Eric Dumazet wrote: > Hi Eric, Thank you for the review! > > > On 2/8/21 6:58 PM, Taehee Yoo wrote: > > Currently, struct ip6_sf_socklist doesn't use list API so that code > > shape is a little bit different from others. > > So it converts ip6_sf_socklist to use list

Re: [PATCH net-next 7/8] mld: convert ip6_sf_socklist to list macros

2021-02-08 Thread kernel test robot
Hi Taehee, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Taehee-Yoo/mld-change-context-from-atomic-to-sleepable/20210209-072339 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/ne

Re: [PATCH net-next 7/8] mld: convert ip6_sf_socklist to list macros

2021-02-08 Thread Eric Dumazet
On 2/8/21 6:58 PM, Taehee Yoo wrote: > Currently, struct ip6_sf_socklist doesn't use list API so that code > shape is a little bit different from others. > So it converts ip6_sf_socklist to use list API so it would > improve readability. > > Signed-off-by: Taehee Yoo > --- > include/net/if_in

[PATCH net-next 7/8] mld: convert ip6_sf_socklist to list macros

2021-02-08 Thread Taehee Yoo
Currently, struct ip6_sf_socklist doesn't use list API so that code shape is a little bit different from others. So it converts ip6_sf_socklist to use list API so it would improve readability. Signed-off-by: Taehee Yoo --- include/net/if_inet6.h | 19 +- include/uapi/linux/in.h | 4 +- net/i