Re: [PATCH net-next 7/7] net: dsa: factor skb freeing on xmit

2017-05-30 Thread Andrew Lunn
On Tue, May 30, 2017 at 10:21:31AM -0400, Vivien Didelot wrote: > The taggers are currently responsible to free the original SKB if they > made a copy of it, or in case of error. > > This patch simplifies this by freeing the original SKB in the > dsa_slave_xmit caller if it differs from the return

[PATCH net-next 7/7] net: dsa: factor skb freeing on xmit

2017-05-30 Thread Vivien Didelot
The taggers are currently responsible to free the original SKB if they made a copy of it, or in case of error. This patch simplifies this by freeing the original SKB in the dsa_slave_xmit caller if it differs from the return SKB (copy or NULL.) At the same time, fix the checkpatch NULL comparison