Re: [PATCH net-next 6/7] dsa: Rename phys_port_mask to user_port_mask

2016-04-11 Thread Andrew Lunn
On Mon, Apr 11, 2016 at 01:03:52PM -0700, Florian Fainelli wrote: > On 11/04/16 12:50, Andrew Lunn wrote: > > The phys in phys_port_mask suggests this mask is about PHYs. In fact, > > it means physical ports. Rename to user_port_mask, indicating user > > ports of the switch, which is hopefully less

Re: [PATCH net-next 6/7] dsa: Rename phys_port_mask to user_port_mask

2016-04-11 Thread Florian Fainelli
On 11/04/16 12:50, Andrew Lunn wrote: > The phys in phys_port_mask suggests this mask is about PHYs. In fact, > it means physical ports. Rename to user_port_mask, indicating user > ports of the switch, which is hopefully less confusing. Even though the change looks fine in principle, I am more wor

[PATCH net-next 6/7] dsa: Rename phys_port_mask to user_port_mask

2016-04-11 Thread Andrew Lunn
The phys in phys_port_mask suggests this mask is about PHYs. In fact, it means physical ports. Rename to user_port_mask, indicating user ports of the switch, which is hopefully less confusing. Signed-off-by: Andrew Lunn --- drivers/net/dsa/bcm_sf2.c | 10 +- drivers/net/dsa/mv88e6060.c