Re: [PATCH net-next 6/6] ionic: useful names for booleans

2020-11-05 Thread Shannon Nelson
On 11/4/20 5:21 PM, Saeed Mahameed wrote: On Wed, 2020-11-04 at 14:33 -0800, Shannon Nelson wrote: With a few more uses of true and false in function calls, we need to give them some useful names so we can tell from the calling point what we're doing. Aha! The root cause of the issue is passin

Re: [PATCH net-next 6/6] ionic: useful names for booleans

2020-11-04 Thread Saeed Mahameed
On Wed, 2020-11-04 at 14:33 -0800, Shannon Nelson wrote: > With a few more uses of true and false in function calls, we > need to give them some useful names so we can tell from the > calling point what we're doing. > Aha! The root cause of the issue is passing booleans to functions in first plac

[PATCH net-next 6/6] ionic: useful names for booleans

2020-11-04 Thread Shannon Nelson
With a few more uses of true and false in function calls, we need to give them some useful names so we can tell from the calling point what we're doing. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_lif.c | 16 drivers/net/ethernet/pensando/ionic/io