Re: [PATCH net-next 6/6] ethtool: specify which header flags are supported per command

2020-10-05 Thread Johannes Berg
On Mon, 2020-10-05 at 12:25 -0700, Jakub Kicinski wrote: > On Mon, 05 Oct 2020 20:58:57 +0200 Johannes Berg wrote: > > On Mon, 2020-10-05 at 08:57 -0700, Jakub Kicinski wrote: > > > @@ -47,19 +61,16 @@ int ethnl_parse_header_dev_get(struct ethnl_req_info > > > *req_info, > > > NL_SET_ERR

Re: [PATCH net-next 6/6] ethtool: specify which header flags are supported per command

2020-10-05 Thread Jakub Kicinski
On Mon, 05 Oct 2020 20:58:57 +0200 Johannes Berg wrote: > On Mon, 2020-10-05 at 08:57 -0700, Jakub Kicinski wrote: > > > > @@ -47,19 +61,16 @@ int ethnl_parse_header_dev_get(struct ethnl_req_info > > *req_info, > > NL_SET_ERR_MSG(extack, "request header missing"); > > retu

Re: [PATCH net-next 6/6] ethtool: specify which header flags are supported per command

2020-10-05 Thread Johannes Berg
On Mon, 2020-10-05 at 08:57 -0700, Jakub Kicinski wrote: > > @@ -47,19 +61,16 @@ int ethnl_parse_header_dev_get(struct ethnl_req_info > *req_info, > NL_SET_ERR_MSG(extack, "request header missing"); > return -EINVAL; > } > + /* Use most permissive header poli

[PATCH net-next 6/6] ethtool: specify which header flags are supported per command

2020-10-05 Thread Jakub Kicinski
Perform header flags validation through the policy. Only pause command supports ETHTOOL_FLAG_STATS. Create a separate policy to be able to express that in policy dumps to user space. Note that even though the core will validate the header policy, it cannot record multiple layers of attributes and