Re: [PATCH net-next 5/7] rhashtable: abstract out function to get hash

2016-09-20 Thread Tom Herbert
On Tue, Sep 20, 2016 at 7:46 PM, Herbert Xu wrote: > On Tue, Sep 20, 2016 at 07:58:03PM +0200, Thomas Graf wrote: >> >> I understand this particular patch as an effort not to duplicate >> hash function selection such as jhash vs jhash2 based on key_len. > > If the rhashtable params stay non-const

Re: [PATCH net-next 5/7] rhashtable: abstract out function to get hash

2016-09-20 Thread Herbert Xu
On Tue, Sep 20, 2016 at 07:58:03PM +0200, Thomas Graf wrote: > > I understand this particular patch as an effort not to duplicate > hash function selection such as jhash vs jhash2 based on key_len. If the rhashtable params stay non-const as is then this is going to produce some monstrous code whi

Re: [PATCH net-next 5/7] rhashtable: abstract out function to get hash

2016-09-20 Thread Thomas Graf
On 09/20/16 at 05:36pm, Herbert Xu wrote: > Tom Herbert wrote: > > Split out most of rht_key_hashfn which is calculating the hash into > > its own function. This way the hash function can be called separately to > > get the hash value. > > > > Acked-by: Thomas Graf > > Signed-off-by: Tom Herbert

Re: [PATCH net-next 5/7] rhashtable: abstract out function to get hash

2016-09-20 Thread Herbert Xu
Tom Herbert wrote: > Split out most of rht_key_hashfn which is calculating the hash into > its own function. This way the hash function can be called separately to > get the hash value. > > Acked-by: Thomas Graf > Signed-off-by: Tom Herbert I don't get this one. You're just using jhash, right

[PATCH net-next 5/7] rhashtable: abstract out function to get hash

2016-09-14 Thread Tom Herbert
Split out most of rht_key_hashfn which is calculating the hash into its own function. This way the hash function can be called separately to get the hash value. Acked-by: Thomas Graf Signed-off-by: Tom Herbert --- include/linux/rhashtable.h | 28 ++-- 1 file changed, 18