Re: [PATCH net-next 5/6] ethtool: fec: sanitize ethtool_fecparam->fec

2021-03-25 Thread Jakub Kicinski
On Thu, 25 Mar 2021 15:00:47 +0300 Dan Carpenter wrote: > Hi Jakub, > > url: > https://github.com/0day-ci/linux/commits/Jakub-Kicinski/ethtool-clarify-the-ethtool-FEC-interface/20210325-091411 > base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git > 69cdfb530f7b8b094e495

Re: [PATCH net-next 5/6] ethtool: fec: sanitize ethtool_fecparam->fec

2021-03-25 Thread Dan Carpenter
Hi Jakub, url: https://github.com/0day-ci/linux/commits/Jakub-Kicinski/ethtool-clarify-the-ethtool-FEC-interface/20210325-091411 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 69cdfb530f7b8b094e49555454869afc8140b1bb config: x86_64-randconfig-m001-20210325 (attache

[PATCH net-next 5/6] ethtool: fec: sanitize ethtool_fecparam->fec

2021-03-24 Thread Jakub Kicinski
Reject NONE on set, this mode means device does not support FEC so it's a little out of place in the set interface. This should be safe to do - user space ethtool does not allow the use of NONE on set. A few drivers treat it the same as OFF, but none use it instead of OFF. Similarly reject an emp