Re: [PATCH net-next 4/8] net: dsa: microchip: add support for phylink management

2021-01-28 Thread Andrew Lunn
> + /* For T1 PHY */ > + if (lan937x_is_internal_t1_phy_port(dev, port)) { > + phylink_set(mask, 100baseT_Full); > + phylink_set_port_modes(mask); Since this is a T1 PHY, you should be using 100baseT1_Full. This might be the first user of this for phylink, so pleas

[PATCH net-next 4/8] net: dsa: microchip: add support for phylink management

2021-01-28 Thread Prasanna Vengateshan
Support for phylink_validate() and reused KSZ commmon API for phylink_mac_link_down() operation Signed-off-by: Prasanna Vengateshan --- drivers/net/dsa/microchip/lan937x_main.c | 40 1 file changed, 40 insertions(+) diff --git a/drivers/net/dsa/microchip/lan937x_main.c