Re: [PATCH net-next 4/6] ethtool: fec: sanitize ethtool_fecparam->active_fec

2021-03-25 Thread Andrew Lunn
On Wed, Mar 24, 2021 at 06:11:58PM -0700, Jakub Kicinski wrote: > struct ethtool_fecparam::active_fec is a GET-only field, > all in-tree drivers correctly ignore it on SET. Clear > the field on SET to avoid any confusion. Again, we can't > reject non-zero now since ethtool user space does not > zer

[PATCH net-next 4/6] ethtool: fec: sanitize ethtool_fecparam->active_fec

2021-03-24 Thread Jakub Kicinski
struct ethtool_fecparam::active_fec is a GET-only field, all in-tree drivers correctly ignore it on SET. Clear the field on SET to avoid any confusion. Again, we can't reject non-zero now since ethtool user space does not zero-init the param correctly. Signed-off-by: Jakub Kicinski --- include/u