Re: [PATCH net-next 4/5] nfp: add .ndo_get_devlink

2019-02-22 Thread Jakub Kicinski
On Fri, 22 Feb 2019 18:27:15 +0100, Michal Kubecek wrote: > > > Maybe it would be safer not to call ndo_get_devlink directly and have > > > an inline wrapper like > > > > > > #if IS_ENABLED(CONFIG_NET_DEVLINK) > > > static inline struct devlink *dev_get_devlink(struct net_device *dev) > > > { > >

Re: [PATCH net-next 4/5] nfp: add .ndo_get_devlink

2019-02-22 Thread Michal Kubecek
On Fri, Feb 22, 2019 at 09:02:04AM -0800, Jakub Kicinski wrote: > On Fri, 22 Feb 2019 11:04:50 +0100, Michal Kubecek wrote: > > On Thu, Feb 21, 2019 at 09:46:19AM -0800, Jakub Kicinski wrote: > > > Support getting devlink instance from a new NDO. > > > > > > Signed-off-by: Jakub Kicinski > > > --

Re: [PATCH net-next 4/5] nfp: add .ndo_get_devlink

2019-02-22 Thread Jakub Kicinski
On Fri, 22 Feb 2019 11:04:50 +0100, Michal Kubecek wrote: > On Thu, Feb 21, 2019 at 09:46:19AM -0800, Jakub Kicinski wrote: > > Support getting devlink instance from a new NDO. > > > > Signed-off-by: Jakub Kicinski > > --- > > drivers/net/ethernet/netronome/nfp/nfp_app.h| 2 ++ > > driv

Re: [PATCH net-next 4/5] nfp: add .ndo_get_devlink

2019-02-22 Thread Michal Kubecek
On Thu, Feb 21, 2019 at 09:46:19AM -0800, Jakub Kicinski wrote: > Support getting devlink instance from a new NDO. > > Signed-off-by: Jakub Kicinski > --- > drivers/net/ethernet/netronome/nfp/nfp_app.h| 2 ++ > drivers/net/ethernet/netronome/nfp/nfp_devlink.c| 11 +++ > driv

[PATCH net-next 4/5] nfp: add .ndo_get_devlink

2019-02-21 Thread Jakub Kicinski
Support getting devlink instance from a new NDO. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_app.h| 2 ++ drivers/net/ethernet/netronome/nfp/nfp_devlink.c| 11 +++ drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 1 + drivers/net/ethernet/n