Re: [PATCH net-next 4/4] net: qualcomm: rmnet: Add support for GRO

2017-10-25 Thread Subash Abhinov Kasiviswanathan
You need to check return code and abort if memory could not be allocated. There is a reason this helper has _init() prefix, it does not belong to _setup() since a _setup() is not expected to fail. Please take a look at other gro_cells_init() callers, and you will notice that it is called from nd

Re: [PATCH net-next 4/4] net: qualcomm: rmnet: Add support for GRO

2017-10-25 Thread Eric Dumazet
On Tue, 2017-10-24 at 22:55 -0600, Subash Abhinov Kasiviswanathan wrote: > Add gro_cells so that rmnet devices can call gro_cells_receive > instead of netif_receive_skb. > > void rmnet_vnd_setup(struct net_device *rmnet_dev) > { > + struct rmnet_priv *priv = netdev_priv(rmnet_dev); > + >

[PATCH net-next 4/4] net: qualcomm: rmnet: Add support for GRO

2017-10-24 Thread Subash Abhinov Kasiviswanathan
Add gro_cells so that rmnet devices can call gro_cells_receive instead of netif_receive_skb. Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/Kconfig | 1 + drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 6 +++--- drivers/net/ethernet/qualcom