Re: [PATCH net-next 4/4] net: ipa: activate some commented assertions

2021-03-19 Thread Andrew Lunn
On Fri, Mar 19, 2021 at 04:18:32PM -0500, Alex Elder wrote: > On 3/19/21 1:32 PM, Andrew Lunn wrote: > > > @@ -212,7 +213,7 @@ static inline u32 ipa_reg_bcr_val(enum ipa_version > > > version) > > > BCR_HOLB_DROP_L2_IRQ_FMASK | > > > BCR_DUAL_TX_

Re: [PATCH net-next 4/4] net: ipa: activate some commented assertions

2021-03-19 Thread Alex Elder
On 3/19/21 1:32 PM, Andrew Lunn wrote: @@ -212,7 +213,7 @@ static inline u32 ipa_reg_bcr_val(enum ipa_version version) BCR_HOLB_DROP_L2_IRQ_FMASK | BCR_DUAL_TX_FMASK; - /* assert(version != IPA_VERSION_4_5); */ + ipa_assert(NULL, version !

Re: [PATCH net-next 4/4] net: ipa: activate some commented assertions

2021-03-19 Thread Andrew Lunn
> @@ -212,7 +213,7 @@ static inline u32 ipa_reg_bcr_val(enum ipa_version > version) > BCR_HOLB_DROP_L2_IRQ_FMASK | > BCR_DUAL_TX_FMASK; > > - /* assert(version != IPA_VERSION_4_5); */ > + ipa_assert(NULL, version != IPA_VERSION_4_5); Hi Alex

Re: [PATCH net-next 4/4] net: ipa: activate some commented assertions

2021-03-19 Thread Alex Elder
On 3/19/21 10:17 AM, Leon Romanovsky wrote: @@ -212,7 +213,7 @@ static inline u32 ipa_reg_bcr_val(enum ipa_version version) BCR_HOLB_DROP_L2_IRQ_FMASK | BCR_DUAL_TX_FMASK; - /* assert(version != IPA_VERSION_4_5); */ + ipa_assert(NULL, ve

Re: [PATCH net-next 4/4] net: ipa: activate some commented assertions

2021-03-19 Thread Leon Romanovsky
On Fri, Mar 19, 2021 at 07:40:21AM -0500, Alex Elder wrote: > On 3/19/21 12:00 AM, Leon Romanovsky wrote: > > On Thu, Mar 18, 2021 at 11:29:23PM -0500, Alex Elder wrote: > > > Convert some commented assertion statements into real calls to > > > ipa_assert(). If the IPA device pointer is available,

Re: [PATCH net-next 4/4] net: ipa: activate some commented assertions

2021-03-19 Thread Alex Elder
On 3/19/21 12:00 AM, Leon Romanovsky wrote: On Thu, Mar 18, 2021 at 11:29:23PM -0500, Alex Elder wrote: Convert some commented assertion statements into real calls to ipa_assert(). If the IPA device pointer is available, provide it, otherwise pass NULL for that. There are lots more places to c

Re: [PATCH net-next 4/4] net: ipa: activate some commented assertions

2021-03-18 Thread Leon Romanovsky
On Thu, Mar 18, 2021 at 11:29:23PM -0500, Alex Elder wrote: > Convert some commented assertion statements into real calls to > ipa_assert(). If the IPA device pointer is available, provide it, > otherwise pass NULL for that. > > There are lots more places to convert, but this serves as an initial

[PATCH net-next 4/4] net: ipa: activate some commented assertions

2021-03-18 Thread Alex Elder
Convert some commented assertion statements into real calls to ipa_assert(). If the IPA device pointer is available, provide it, otherwise pass NULL for that. There are lots more places to convert, but this serves as an initial verification of the new mechanism. The assertions here implement bot