Re: [PATCH net-next 3/7] afs: switch to in_dev_for_each_ifa_rcu

2019-05-29 Thread Florian Westphal
David Howells wrote: > Actually, whilst thanks are due for doing the work - it looks nicer now - I'm > told that there's not really any point populating the list. Current OpenAFS > ignores it, as does AuriStor - and IBM AFS 3.6 will do the right thing. [..] > On that basis, feel free to make it

Re: [PATCH net-next 3/7] afs: switch to in_dev_for_each_ifa_rcu

2019-05-29 Thread David Howells
Florian Westphal wrote: > The in_dev_for_each_ifa_rcu helper gets used so sparse won't > complain when we add the proper __rcu annotation to the ifa_list > member in struct in_device later. > > While doing this I realized the helper only has one call site, > so move it to where its needed. > >

[PATCH net-next 3/7] afs: switch to in_dev_for_each_ifa_rcu

2019-05-29 Thread Florian Westphal
The in_dev_for_each_ifa_rcu helper gets used so sparse won't complain when we add the proper __rcu annotation to the ifa_list member in struct in_device later. While doing this I realized the helper only has one call site, so move it to where its needed. This then revealed that we allocate a temp