Re: [PATCH net-next 3/6] ethtool: fec: sanitize ethtool_fecparam->reserved

2021-03-25 Thread Jakub Kicinski
On Thu, 25 Mar 2021 13:22:47 +0100 Andrew Lunn wrote: > On Wed, Mar 24, 2021 at 06:11:57PM -0700, Jakub Kicinski wrote: > > struct ethtool_fecparam::reserved is never looked at by the core. > > Make sure it's actually 0. Unfortunately we can't return an error > > because old ethtool doesn't zero-in

Re: [PATCH net-next 3/6] ethtool: fec: sanitize ethtool_fecparam->reserved

2021-03-25 Thread Andrew Lunn
On Wed, Mar 24, 2021 at 06:11:57PM -0700, Jakub Kicinski wrote: > struct ethtool_fecparam::reserved is never looked at by the core. > Make sure it's actually 0. Unfortunately we can't return an error > because old ethtool doesn't zero-initialize the structure for SET. Hi Jakub What makes it total

[PATCH net-next 3/6] ethtool: fec: sanitize ethtool_fecparam->reserved

2021-03-24 Thread Jakub Kicinski
struct ethtool_fecparam::reserved is never looked at by the core. Make sure it's actually 0. Unfortunately we can't return an error because old ethtool doesn't zero-initialize the structure for SET. On GET we can be more verbose, there are no in tree (ab)users. Fix up the kdoc on the structure. Re