Re: [PATCH net-next 3/6] ethtool: add FEC statistics

2021-04-15 Thread Saeed Mahameed
On Thu, 2021-04-15 at 08:21 -0700, Jakub Kicinski wrote: > On Wed, 14 Apr 2021 23:25:43 -0700 Saeed Mahameed wrote: > > On Tue, 2021-04-13 at 20:44 -0700, Jakub Kicinski wrote: > > > ethtool_link_ksettings *); > > > +   void(*get_fec_stats)(struct net_device *dev, > > > +   

Re: [PATCH net-next 3/6] ethtool: add FEC statistics

2021-04-15 Thread Jakub Kicinski
On Wed, 14 Apr 2021 23:25:43 -0700 Saeed Mahameed wrote: > On Tue, 2021-04-13 at 20:44 -0700, Jakub Kicinski wrote: > > ethtool_link_ksettings *); > > +   void(*get_fec_stats)(struct net_device *dev, > > +    struct ethtool_fec_stats *fec_stats); > > why void

Re: [PATCH net-next 3/6] ethtool: add FEC statistics

2021-04-14 Thread Saeed Mahameed
On Tue, 2021-04-13 at 20:44 -0700, Jakub Kicinski wrote: > ethtool_link_ksettings *); > +   void(*get_fec_stats)(struct net_device *dev, > +    struct ethtool_fec_stats > *fec_stats); why void ? some drivers need to access the FW and it could be an old FW/device

[PATCH net-next 3/6] ethtool: add FEC statistics

2021-04-13 Thread Jakub Kicinski
Similarly to pause statistics add stats for FEC. The IEEE standard mandates two sets of counters: - 30.5.1.1.17 aFECCorrectedBlocks - 30.5.1.1.18 aFECUncorrectableBlocks where block is a block of bits FEC operates on. Each of these counters is defined per lane (PCS instance). Multiple vendors p