Re: [PATCH net-next 3/4] vxlan: remove gro_cell support

2016-07-08 Thread Eric Dumazet
On Fri, 2016-07-08 at 11:55 -0400, Hannes Frederic Sowa wrote: > Exactly, thus we are also only touching UDP tunneling protocols at the > moment. Did you nack the removal of gro_cell support from the udp > protocols or are you fine with it, given that we won't take away the > functionality to spre

Re: [PATCH net-next 3/4] vxlan: remove gro_cell support

2016-07-08 Thread Hannes Frederic Sowa
On 08.07.2016 11:33, Eric Dumazet wrote: > On Fri, 2016-07-08 at 11:12 -0400, Hannes Frederic Sowa wrote: >> Hi Eric, >> >> On 07.07.2016 12:13, Eric Dumazet wrote: >>> On Thu, 2016-07-07 at 17:58 +0200, Paolo Abeni wrote: GRO is now handled entirely by the udp_offload layer and there is no n

Re: [PATCH net-next 3/4] vxlan: remove gro_cell support

2016-07-08 Thread Eric Dumazet
On Fri, 2016-07-08 at 11:12 -0400, Hannes Frederic Sowa wrote: > Hi Eric, > > On 07.07.2016 12:13, Eric Dumazet wrote: > > On Thu, 2016-07-07 at 17:58 +0200, Paolo Abeni wrote: > >> GRO is now handled entirely by the udp_offload layer and there is no need > >> for trying it again at the device le

Re: [PATCH net-next 3/4] vxlan: remove gro_cell support

2016-07-08 Thread Hannes Frederic Sowa
Hi Eric, On 07.07.2016 12:13, Eric Dumazet wrote: > On Thu, 2016-07-07 at 17:58 +0200, Paolo Abeni wrote: >> GRO is now handled entirely by the udp_offload layer and there is no need >> for trying it again at the device level. We can drop gro_cell usage, >> simplifying the driver a bit, while mai

Re: [PATCH net-next 3/4] vxlan: remove gro_cell support

2016-07-08 Thread Paolo Abeni
On Thu, 2016-07-07 at 18:13 +0200, Eric Dumazet wrote: > On Thu, 2016-07-07 at 17:58 +0200, Paolo Abeni wrote: > > GRO is now handled entirely by the udp_offload layer and there is no need > > for trying it again at the device level. We can drop gro_cell usage, > > simplifying the driver a bit, wh

Re: [PATCH net-next 3/4] vxlan: remove gro_cell support

2016-07-07 Thread Eric Dumazet
On Thu, 2016-07-07 at 17:58 +0200, Paolo Abeni wrote: > GRO is now handled entirely by the udp_offload layer and there is no need > for trying it again at the device level. We can drop gro_cell usage, > simplifying the driver a bit, while maintaining the same performance for > TCP and improving sl

[PATCH net-next 3/4] vxlan: remove gro_cell support

2016-07-07 Thread Paolo Abeni
GRO is now handled entirely by the udp_offload layer and there is no need for trying it again at the device level. We can drop gro_cell usage, simplifying the driver a bit, while maintaining the same performance for TCP and improving slightly for UDP. This basically reverts the commit 58ce31cca1ff