Re: [PATCH net-next 3/4] tcp: add SACK compression

2018-05-17 Thread Yuchung Cheng
On Thu, May 17, 2018 at 9:59 AM, Yuchung Cheng wrote: > On Thu, May 17, 2018 at 9:41 AM, Neal Cardwell wrote: >> >> On Thu, May 17, 2018 at 11:40 AM Eric Dumazet >> wrote: >> > On 05/17/2018 08:14 AM, Neal Cardwell wrote: >> > > Is there a particular motivation for the cap of 127? IMHO 127 ACKs

Re: [PATCH net-next 3/4] tcp: add SACK compression

2018-05-17 Thread Eric Dumazet
On Thu, May 17, 2018 at 9:59 AM Yuchung Cheng wrote: > > > > Thanks for implementing this! Overall this patch seems nice to me. > > > > Acked-by: Neal Cardwell > > > > BTW, I guess we should spread the word to maintainers of other major TCP > > stacks that they need to be prepared for what may be

Re: [PATCH net-next 3/4] tcp: add SACK compression

2018-05-17 Thread Yuchung Cheng
On Thu, May 17, 2018 at 9:41 AM, Neal Cardwell wrote: > > On Thu, May 17, 2018 at 11:40 AM Eric Dumazet > wrote: > > On 05/17/2018 08:14 AM, Neal Cardwell wrote: > > > Is there a particular motivation for the cap of 127? IMHO 127 ACKs is > quite > > > a few to compress. Experience seems to show t

Re: [PATCH net-next 3/4] tcp: add SACK compression

2018-05-17 Thread Neal Cardwell
On Thu, May 17, 2018 at 11:40 AM Eric Dumazet wrote: > On 05/17/2018 08:14 AM, Neal Cardwell wrote: > > Is there a particular motivation for the cap of 127? IMHO 127 ACKs is quite > > a few to compress. Experience seems to show that it works well to have one > > GRO ACK for ~64KBytes that triggers

Re: [PATCH net-next 3/4] tcp: add SACK compression

2018-05-17 Thread Eric Dumazet
On 05/17/2018 08:40 AM, Eric Dumazet wrote: > > > On 05/17/2018 08:14 AM, Neal Cardwell wrote: >> Any particular motivation for the 2.5ms here? It might be nice to match the >> existing TSO autosizing dynamics and use 1ms here instead of having a >> separate new constant of 2.5ms. Smaller time

Re: [PATCH net-next 3/4] tcp: add SACK compression

2018-05-17 Thread Eric Dumazet
On 05/17/2018 08:14 AM, Neal Cardwell wrote: > On Thu, May 17, 2018 at 8:12 AM Eric Dumazet wrote: > >> When TCP receives an out-of-order packet, it immediately sends >> a SACK packet, generating network load but also forcing the >> receiver to send 1-MSS pathological packets, increasing its >>

Re: [PATCH net-next 3/4] tcp: add SACK compression

2018-05-17 Thread Neal Cardwell
On Thu, May 17, 2018 at 8:12 AM Eric Dumazet wrote: > When TCP receives an out-of-order packet, it immediately sends > a SACK packet, generating network load but also forcing the > receiver to send 1-MSS pathological packets, increasing its > RTX queue length/depth, and thus processing time. > W

[PATCH net-next 3/4] tcp: add SACK compression

2018-05-17 Thread Eric Dumazet
When TCP receives an out-of-order packet, it immediately sends a SACK packet, generating network load but also forcing the receiver to send 1-MSS pathological packets, increasing its RTX queue length/depth, and thus processing time. Wifi networks suffer from this aggressive behavior, but generally