Re: [PATCH net-next 3/4] page_pool: Restructure __page_pool_put_page()

2019-10-23 Thread Saeed Mahameed
On Wed, 2019-10-23 at 20:31 +0200, Jesper Dangaard Brouer wrote: > On Wed, 23 Oct 2019 11:45:15 +0300 > Ilias Apalodimas wrote: > > > On Tue, Oct 22, 2019 at 04:44:24AM +, Saeed Mahameed wrote: > > > From: Jonathan Lemon > > > > > > 1) Rename functions to reflect what they are actually doin

Re: [PATCH net-next 3/4] page_pool: Restructure __page_pool_put_page()

2019-10-23 Thread Jesper Dangaard Brouer
On Wed, 23 Oct 2019 11:45:15 +0300 Ilias Apalodimas wrote: > On Tue, Oct 22, 2019 at 04:44:24AM +, Saeed Mahameed wrote: > > From: Jonathan Lemon > > > > 1) Rename functions to reflect what they are actually doing. > > > > 2) Unify the condition to keep a page. > > > > 3) When page can't

Re: [PATCH net-next 3/4] page_pool: Restructure __page_pool_put_page()

2019-10-23 Thread Ilias Apalodimas
On Tue, Oct 22, 2019 at 04:44:24AM +, Saeed Mahameed wrote: > From: Jonathan Lemon > > 1) Rename functions to reflect what they are actually doing. > > 2) Unify the condition to keep a page. > > 3) When page can't be kept in cache, fallback to releasing page to page > allocator in one place

[PATCH net-next 3/4] page_pool: Restructure __page_pool_put_page()

2019-10-21 Thread Saeed Mahameed
From: Jonathan Lemon 1) Rename functions to reflect what they are actually doing. 2) Unify the condition to keep a page. 3) When page can't be kept in cache, fallback to releasing page to page allocator in one place, instead of calling it from multiple conditions, and reuse __page_pool_return_p