Re: [PATCH net-next 3/4] ipv6: Use hash-threshold instead of modulo-N

2018-01-10 Thread Ido Schimmel
On Tue, Jan 09, 2018 at 08:54:00PM -0700, David Ahern wrote: > Did you consider adding the net->ipv4.sysctl_fib_multipath_use_neigh > check as well? ie., if set, verify neighbor is alive before picking that hop No, but I'll add it to my TODO list. It's what effectively happens in mlxsw. If the ne

Re: [PATCH net-next 3/4] ipv6: Use hash-threshold instead of modulo-N

2018-01-09 Thread David Ahern
On 1/9/18 7:40 AM, Ido Schimmel wrote: > Now that each nexthop stores its region boundary in the multipath hash > function's output space, we can use hash-threshold instead of modulo-N > in multipath selection. > > This reduces the number of checks we need to perform during lookup, as > dead and l

[PATCH net-next 3/4] ipv6: Use hash-threshold instead of modulo-N

2018-01-09 Thread Ido Schimmel
Now that each nexthop stores its region boundary in the multipath hash function's output space, we can use hash-threshold instead of modulo-N in multipath selection. This reduces the number of checks we need to perform during lookup, as dead and linkdown nexthops are assigned a negative region bou