RE: [PATCH net-next 3/3] mlxsw: core: Add support for negative temperature readout

2019-06-23 Thread Vadim Pasternak
> -Original Message- > From: Andrew Lunn > Sent: Sunday, June 23, 2019 7:26 PM > To: Vadim Pasternak > Cc: Ido Schimmel ; netdev@vger.kernel.org; > da...@davemloft.net; Jiri Pirko ; mlxsw > ; Ido Schimmel > Subject: Re: [PATCH net-next 3/3] mlxsw: core:

Re: [PATCH net-next 3/3] mlxsw: core: Add support for negative temperature readout

2019-06-23 Thread Andrew Lunn
> > Why the > 0? > > We don't consider negative temperature for thermal control. Is this because the thermal control is also broken and does not support negative values? This is just a workaround papering over the cracks? I've worked on some systems where the thermal subsystem has controller a h

RE: [PATCH net-next 3/3] mlxsw: core: Add support for negative temperature readout

2019-06-23 Thread Vadim Pasternak
> -Original Message- > From: Vadim Pasternak > Sent: Sunday, June 23, 2019 7:01 PM > To: Andrew Lunn ; Ido Schimmel > Cc: netdev@vger.kernel.org; da...@davemloft.net; Jiri Pirko > ; mlxsw ; Ido Schimmel > > Subject: RE: [PATCH net-next 3/3] mlxsw: core:

RE: [PATCH net-next 3/3] mlxsw: core: Add support for negative temperature readout

2019-06-23 Thread Vadim Pasternak
> -Original Message- > From: Andrew Lunn > Sent: Sunday, June 23, 2019 6:44 PM > To: Ido Schimmel > Cc: netdev@vger.kernel.org; da...@davemloft.net; Jiri Pirko > ; mlxsw ; Vadim Pasternak > ; Ido Schimmel > Subject: Re: [PATCH net-next 3/3] mlxsw: core:

Re: [PATCH net-next 3/3] mlxsw: core: Add support for negative temperature readout

2019-06-23 Thread Andrew Lunn
> --- a/drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c > +++ b/drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c > @@ -52,8 +52,7 @@ static ssize_t mlxsw_hwmon_temp_show(struct device *dev, > container_of(attr, struct mlxsw_hwmon_attr, dev_attr); > struct mlxsw_hwmon *m

[PATCH net-next 3/3] mlxsw: core: Add support for negative temperature readout

2019-06-23 Thread Ido Schimmel
From: Vadim Pasternak Extend macros MLXSW_REG_MTMP_TEMP_TO_MC() to allow support of negative temperature readout, since chip and others thermal components are capable of operating within the negative temperature. With no such support negative temperature will be consider as very high temperature