Re: [PATCH net-next 3/3] dsa: bmc_sf2: Pass GENMASK() signed bits

2020-07-05 Thread Florian Fainelli
On 7/5/2020 1:36 PM, Andrew Lunn wrote: > Oddly, GENMASK() requires signed bit numbers, so that it can compare > them for < 0. If passed an unsigned type, we get warnings about the > test never being true. There is no danger of overflow here, udf is > always a u8, so there is plenty of space whe

[PATCH net-next 3/3] dsa: bmc_sf2: Pass GENMASK() signed bits

2020-07-05 Thread Andrew Lunn
Oddly, GENMASK() requires signed bit numbers, so that it can compare them for < 0. If passed an unsigned type, we get warnings about the test never being true. There is no danger of overflow here, udf is always a u8, so there is plenty of space when expanding to an int. Signed-off-by: Andrew Lunn