Re: [PATCH net-next 2/7] net: dsa: Add devlink regions support to DSA

2020-08-16 Thread Vladimir Oltean
On Mon, Aug 17, 2020 at 12:06:32AM +0200, Andrew Lunn wrote: > > Could we perhaps open-code these from the drivers themselves? There's > > hardly any added value in DSA providing a "helper" for creation of > > devlink resources (regions, shared buffers, etc). > > If we do change to open coding, wou

Re: [PATCH net-next 2/7] net: dsa: Add devlink regions support to DSA

2020-08-16 Thread Andrew Lunn
> Could we perhaps open-code these from the drivers themselves? There's > hardly any added value in DSA providing a "helper" for creation of > devlink resources (regions, shared buffers, etc). It is something i considered. But we already have devlink wrappers. It would be odd to have some parts o

Re: [PATCH net-next 2/7] net: dsa: Add devlink regions support to DSA

2020-08-16 Thread Vladimir Oltean
On Sun, Aug 16, 2020 at 09:43:11PM +0200, Andrew Lunn wrote: > Allow DSA drivers to make use of devlink regions, via simple wrappers. > > Signed-off-by: Andrew Lunn > --- > include/net/dsa.h | 6 ++ > net/dsa/dsa.c | 16 > 2 files changed, 22 insertions(+) > > diff --g

[PATCH net-next 2/7] net: dsa: Add devlink regions support to DSA

2020-08-16 Thread Andrew Lunn
Allow DSA drivers to make use of devlink regions, via simple wrappers. Signed-off-by: Andrew Lunn --- include/net/dsa.h | 6 ++ net/dsa/dsa.c | 16 2 files changed, 22 insertions(+) diff --git a/include/net/dsa.h b/include/net/dsa.h index 63ff6f717307..8963440ec7f8 100