Re: [PATCH net-next 2/5] rhashtable: Add rhastable_walk_peek

2017-11-30 Thread Tom Herbert
On Thu, Nov 30, 2017 at 5:21 PM, Herbert Xu wrote: > On Thu, Nov 30, 2017 at 05:15:16PM -0800, Tom Herbert wrote: >> >> We don't need a guarantee of stability, but what I am seeing is that >> we're consisitently dropping entries on when doing a multi-part >> netlink walk. We start iterating over t

Re: [PATCH net-next 2/5] rhashtable: Add rhastable_walk_peek

2017-11-30 Thread Herbert Xu
On Thu, Nov 30, 2017 at 05:15:16PM -0800, Tom Herbert wrote: > > We don't need a guarantee of stability, but what I am seeing is that > we're consisitently dropping entries on when doing a multi-part > netlink walk. We start iterating over the table filling in the netlink > info. But eventually the

Re: [PATCH net-next 2/5] rhashtable: Add rhastable_walk_peek

2017-11-30 Thread Tom Herbert
On Thu, Nov 30, 2017 at 4:38 PM, Herbert Xu wrote: > On Thu, Nov 30, 2017 at 04:03:02PM -0800, Tom Herbert wrote: >> This function is like rhashtable_walk_next except that it only returns >> the current element in the inter and does not advance the iter. >> >> This patch also creates __rhashtable_

Re: [PATCH net-next 2/5] rhashtable: Add rhastable_walk_peek

2017-11-30 Thread Herbert Xu
On Thu, Nov 30, 2017 at 04:03:02PM -0800, Tom Herbert wrote: > This function is like rhashtable_walk_next except that it only returns > the current element in the inter and does not advance the iter. > > This patch also creates __rhashtable_walk_find_next. It finds the next > element in the table

[PATCH net-next 2/5] rhashtable: Add rhastable_walk_peek

2017-11-30 Thread Tom Herbert
This function is like rhashtable_walk_next except that it only returns the current element in the inter and does not advance the iter. This patch also creates __rhashtable_walk_find_next. It finds the next element in the table when the entry cached in iter is NULL or at the end of a slot. __rhasht