Re: [PATCH net-next 2/4] qede: Simplify the usage of qede-flags.

2018-11-23 Thread David Miller
From: Sudarsana Reddy Kalluru Date: Thu, 22 Nov 2018 22:44:49 -0800 > - edev->flags |= QEDE_FLAG_IS_VF; > + set_bit(QEDE_FLAGS_IS_VF, &edev->flags); ... > - edev->flags |= QEDE_TX_TIMESTAMPING_EN; > + set_bit(QEDE_FLAGS_TX_TIMESTAMPING_EN, &edev->fl

[PATCH net-next 2/4] qede: Simplify the usage of qede-flags.

2018-11-22 Thread Sudarsana Reddy Kalluru
The values represented by qede->flags is being used in mixed ways: 1. As 'value' at some places e.g., QEDE_FLAGS_IS_VF usage 2. As bit-mask(value) at some places e.g., QEDE_FLAGS_PTP_TX_IN_PRORGESS usage. This implementation pose problems in future when we want to add more flag values e.g.