Re: [PATCH net-next 2/4] net: dsa: Add wrappers for overloaded ndo_ops

2020-07-19 Thread Florian Fainelli
On 7/19/2020 8:40 AM, Andrew Lunn wrote: >> +#if IS_ENABLED(CONFIG_NET_DSA) >> +#define dsa_build_ndo_op(name, arg1_type, arg1_name, arg2_type, arg2_name) \ >> +static int inline dsa_##name(struct net_device *dev, arg1_type arg1_name, \ >> + arg2_type arg2_name) \ >

Re: [PATCH net-next 2/4] net: dsa: Add wrappers for overloaded ndo_ops

2020-07-19 Thread Andrew Lunn
> +#if IS_ENABLED(CONFIG_NET_DSA) > +#define dsa_build_ndo_op(name, arg1_type, arg1_name, arg2_type, arg2_name) \ > +static int inline dsa_##name(struct net_device *dev, arg1_type arg1_name, \ > + arg2_type arg2_name) \ > +{

Re: [PATCH net-next 2/4] net: dsa: Add wrappers for overloaded ndo_ops

2020-07-18 Thread Florian Fainelli
On 7/18/2020 1:18 PM, Vladimir Oltean wrote: > On Sat, Jul 18, 2020 at 11:53:52AM -0700, Florian Fainelli wrote: >> >> >> On 7/17/2020 9:53 PM, kernel test robot wrote: >>> Hi Florian, >>> >>> I love your patch! Perhaps something to improve: >>> >>> [auto build test WARNING on net-next/master] >

Re: [PATCH net-next 2/4] net: dsa: Add wrappers for overloaded ndo_ops

2020-07-18 Thread Vladimir Oltean
On Sat, Jul 18, 2020 at 11:53:52AM -0700, Florian Fainelli wrote: > > > On 7/17/2020 9:53 PM, kernel test robot wrote: > > Hi Florian, > > > > I love your patch! Perhaps something to improve: > > > > [auto build test WARNING on net-next/master] > > > > url: > > https://github.com/0day-ci/l

Re: [PATCH net-next 2/4] net: dsa: Add wrappers for overloaded ndo_ops

2020-07-18 Thread Florian Fainelli
On 7/17/2020 9:53 PM, kernel test robot wrote: > Hi Florian, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-dsa-Setup-dsa_netdev_ops/20200718-110931 > base: ht

Re: [PATCH net-next 2/4] net: dsa: Add wrappers for overloaded ndo_ops

2020-07-17 Thread kernel test robot
Hi Florian, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-dsa-Setup-dsa_netdev_ops/20200718-110931 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git dc

[PATCH net-next 2/4] net: dsa: Add wrappers for overloaded ndo_ops

2020-07-17 Thread Florian Fainelli
Add definitions for the dsa_netdevice_ops structure which is a subset of the net_device_ops structure for the specific operations that we care about overlaying on top of the DSA CPU port net_device and provide inline stubs that take core managing whether DSA code is reachable. Signed-off-by: Flori