Re: [PATCH net-next 2/3] qeth: Convert use of __constant_htons to htons

2015-08-20 Thread David Miller
From: Vaishali Thakkar Date: Fri, 21 Aug 2015 00:28:59 +0530 > On Thu, Aug 20, 2015 at 11:28 PM, David Miller wrote: >> From: Ursula Braun >> Date: Thu, 20 Aug 2015 15:53:42 +0200 >> >>> qeth is an s390-driver, and s390 is a big-endian architecture. Thus >>> arguments valid for little-endian do

Re: [PATCH net-next 2/3] qeth: Convert use of __constant_htons to htons

2015-08-20 Thread Vaishali Thakkar
On Thu, Aug 20, 2015 at 11:28 PM, David Miller wrote: > From: Ursula Braun > Date: Thu, 20 Aug 2015 15:53:42 +0200 > >> qeth is an s390-driver, and s390 is a big-endian architecture. Thus >> arguments valid for little-endian do not apply to qeth-code. > > You can not throw out generally good tree

Re: [PATCH net-next 2/3] qeth: Convert use of __constant_htons to htons

2015-08-20 Thread David Miller
From: Ursula Braun Date: Thu, 20 Aug 2015 15:53:42 +0200 > qeth is an s390-driver, and s390 is a big-endian architecture. Thus > arguments valid for little-endian do not apply to qeth-code. You can not throw out generally good tree-wide conventions just because it happens to work on your platfor

RE: [PATCH net-next 2/3] qeth: Convert use of __constant_htons to htons

2015-08-20 Thread Ursula Braun
On Thu, 2015-08-20 at 11:51 +, David Laight wrote: > From: Ursula Braun [mailto:ubr...@linux.vnet.ibm.com] > > Sent: 20 August 2015 12:44 > > On Thu, 2015-08-20 at 10:46 +, David Laight wrote: > > > From: Ursula Braun > > > > Sent: 19 August 2015 09:21 > > > > In little endian cases, the ma

RE: [PATCH net-next 2/3] qeth: Convert use of __constant_htons to htons

2015-08-20 Thread David Laight
From: Ursula Braun [mailto:ubr...@linux.vnet.ibm.com] > Sent: 20 August 2015 12:44 > On Thu, 2015-08-20 at 10:46 +, David Laight wrote: > > From: Ursula Braun > > > Sent: 19 August 2015 09:21 > > > In little endian cases, the macro htons unfolds to __swab16 which > > > provides special case for

RE: [PATCH net-next 2/3] qeth: Convert use of __constant_htons to htons

2015-08-20 Thread Ursula Braun
On Thu, 2015-08-20 at 10:46 +, David Laight wrote: > From: Ursula Braun > > Sent: 19 August 2015 09:21 > > In little endian cases, the macro htons unfolds to __swab16 which > > provides special case for constants. In big endian cases, > > __constant_htons and htons expand directly to the same e

RE: [PATCH net-next 2/3] qeth: Convert use of __constant_htons to htons

2015-08-20 Thread David Laight
From: Ursula Braun > Sent: 19 August 2015 09:21 > In little endian cases, the macro htons unfolds to __swab16 which > provides special case for constants. In big endian cases, > __constant_htons and htons expand directly to the same expression. > So, replace __constant_htons with htons with the goa

[PATCH net-next 2/3] qeth: Convert use of __constant_htons to htons

2015-08-19 Thread Ursula Braun
From: Vaishali Thakkar In little endian cases, the macro htons unfolds to __swab16 which provides special case for constants. In big endian cases, __constant_htons and htons expand directly to the same expression. So, replace __constant_htons with htons with the goal of getting rid of the definit